From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id BEF76385780E for ; Fri, 21 Jan 2022 12:17:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BEF76385780E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 634653431B8; Fri, 21 Jan 2022 12:17:53 +0000 (UTC) Date: Fri, 21 Jan 2022 07:17:55 -0500 From: Mike Frysinger To: newlib@sourceware.org Subject: Re: [PATCH 1/2] newlib: move to ../config/multi.m4 for multilib logic Message-ID: Mail-Followup-To: newlib@sourceware.org References: <20220121035823.11754-1-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Fk6MQCNnOCZCTQs1" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Jan 2022 12:17:57 -0000 --Fk6MQCNnOCZCTQs1 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 21 Jan 2022 12:23, Corinna Vinschen wrote: > On Jan 20 22:58, Mike Frysinger wrote: > > The current newlib multilib logic is almost exactly the same as the > > config/multi.m4, and the differences should be minor, so switch over > > to that to delete custom logic on ourside. >=20 > What differences are that? the differences don't affect the actual compilation. newlib/configure.ac uses AC_CONFIG_FILES to hack up Makefile. multi.m4 uses AC_OUTPUT_COMMANDS instead. newlib/configure.ac passes LDFLAGS to init-cmds while multi.m4 does not (it does pass additional non-C toolchain vars that newlib doesn't use). afaict omitting LDFLAGS shouldn't make a diff since newlib has been clobbering that with an invalid setting ($ldflags). there's also a few internal variable names that changed, but since newlib doesn't check them, it shouldn't matter. > Did you check them? yes, i've build every commit against bfin-elf multilib. if you want me to check something specifically, please highlight it. -mike --Fk6MQCNnOCZCTQs1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmHqpHMACgkQQWM7n+g3 9YHldBAAtO0Q06LdtyRfEhe88k2UjbcjwymLJ2WcYVLoRX/VbaF9f9o/6Lw3D86i a2ZSFoYJY0U1p6irLKhT0YgnG/HdOCEp1j50sQma1SQvk9ap56qwZPdHHOtL3zRt dqvvDYkQGj7pk9oj6iR/e3RHZizjBogp9qJUpvltGKG1rgzuoifVLieXvk31esr4 D/0CcykZ2ZKtfZqQltsZiLydIgdgSx0++WpWQwuWxtBWcPfpk9QAsOvrRCyBJMpy r2HMpeLa5id323Sli3zvvT4dEqNr0P2aewrCqEsSAM1ELvFIbH7Z65jdcw0pmu34 IqooTJQWO49yy+xnfqyEeGEowCiM9lS0cr29wogxXNJIjajPhvPc3JvoIOYx39LR fs/LPvzgLWUTAVsyrDqm5X9imKnd7rCdEic7eA51p/CB3wMZ/fT1ubxKebDijAxD N+V1oCk0mWYnEWvfU3aokFsgFq2HNRxUPeSmjF0tY6OypDyXRkII+ibjKaVbvsCU C79hFYPARSt60jjxXm2MWXBuHmun8XHeAxaRwhsZ/XKfOukW0gd9GXWwVlYtQ/Hp WnqO0uhq+A/JZQHaoauNLfF/kB+SOkZOlACnnaj74hzmwoUFFtl+a6YSipBIly7e blDaeW+pHW2Cj8tRlRqY5wrD8uugcyA9B7AJytWEDvKlXHBpl/4= =TOVo -----END PGP SIGNATURE----- --Fk6MQCNnOCZCTQs1--