From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 1534C3858C2C for ; Fri, 21 Jan 2022 12:39:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1534C3858C2C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 9170934349E; Fri, 21 Jan 2022 12:39:09 +0000 (UTC) Date: Fri, 21 Jan 2022 07:39:11 -0500 From: Mike Frysinger To: newlib@sourceware.org Subject: Re: [PATCH] newlib: switch to autoconf long double wider macro Message-ID: Mail-Followup-To: newlib@sourceware.org References: <20220121050411.23094-1-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="F2qTGwjBkjhw8Rht" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Jan 2022 12:39:14 -0000 --F2qTGwjBkjhw8Rht Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 21 Jan 2022 12:27, Corinna Vinschen wrote: > On Jan 21 00:04, Mike Frysinger wrote: > > Now that we require a recent version of autoconf, we can rely on this > > macro existing. It has inverted semantics from the existing test (it > > looks for "is wider" instead of "is equal"), so we have to invert the > > check when creating our _LDBL_EQ_DBL. > > --- > > newlib/configure | 72 +++++++++++++++++++++++++++++---------------- > > newlib/configure.ac | 22 ++------------ > > newlib/newlib.hin | 4 +++ > > 3 files changed, 53 insertions(+), 45 deletions(-) >=20 > Looks right to me, please push. for posterity, i'll note that autoconf uses a different (more comprehensive) testing method that ultimately arrives at a diff answer than what newlib is atm. for aarch64, _LDBL_EQ_DBL is now defined when it wasn't before. newlib today is doing: #if DBL_MANT_DIG =3D=3D LDBL_MANT_DIG && \ LDBL_MIN_EXP =3D=3D DBL_MIN_EXP && \ LDBL_MAX_EXP =3D=3D DBL_MAX_EXP #define _LDBL_EQ_DBL #else #error "LDBL !=3D DBL" #endif while autoconf is doing: (0 < ((DBL_MAX_EXP < LDBL_MAX_EXP) + (DBL_MANT_DIG < LDBL_MANT_DIG) - (LDBL_MAX_EXP < DBL_MAX_EXP) - (LDBL_MANT_DIG < DBL_MANT_DIG))) && (int) LDBL_EPSILON =3D=3D 0 -mike --F2qTGwjBkjhw8Rht Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmHqqW8ACgkQQWM7n+g3 9YHYBxAA1aLhp98+LUOduzPMZGaxu2cwkksThIoETPP3J1ZKvEtkBsJQT3jCq+db uOfTDQdsG7YLuJDPr2Tdf1NNat4GTcS8tzXcJvPUf2gP5aaOpM/LA9EF9bgVABjR oxomJl/of8swG49wnjqsXN1yCJCP35RWIazVPm1l43MKfh/VL2LVG1BP3lzLOHQv 2/ZEF9t0EF54n/4O6UK5snNTl9CI161IMSq5o/Di8He7skybkOmjBMesGJEi7T1+ hgypYYWq+T5LD8u/rW/5fwm1xf6sRudnfGGKHI6e3ED3LcLyzmmQ9kvmhUTqHiFi PBtEGoRhCqQ6ckLrH02JTVNXU6muoVXCwwgxRq8q9m9yh5pk2UG4+4oIa2owb5S/ N9e8C53HFpe49cQIhgLRwEqj8dWWQOL5QfmUEErIhCLsbNXS1DtuFf+0hrAUGzNy 51VmOVLdBtlsifyFe9SNlGE8TxXvU2vG8EHWhPyTrpGtzRjw62PNd7p2m+AgSB5e XG/IGS9+UoWCASN2hVkcGEU43Q7PPxUtUYMOUugGxwhgu1Hi/YrVDCiChpBe0hwB /pi4Yix0HMrChQHlmWBHWOh7EEdFgfKItQ9/XQA6De6xi15qcveA9HPYqg2wrAiA ffgt/dZjdO1nuhwSaj7TX3IYwDBIm+InyrzkowonWcBaAuWDack= =8XN6 -----END PGP SIGNATURE----- --F2qTGwjBkjhw8Rht--