From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 2094E3945C38 for ; Thu, 27 Jan 2022 02:32:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2094E3945C38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 97682342FC1; Thu, 27 Jan 2022 02:32:06 +0000 (UTC) Date: Wed, 26 Jan 2022 21:32:10 -0500 From: Mike Frysinger To: newlib@sourceware.org Subject: Re: [PATCH 1/3] libgloss: merge epiphany & libnosys & or1k configure scripts up a level Message-ID: Mail-Followup-To: newlib@sourceware.org References: <20220126094508.24259-1-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZG5ClwI3tedzx0dY" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jan 2022 02:32:10 -0000 --ZG5ClwI3tedzx0dY Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 26 Jan 2022 13:30, Corinna Vinschen wrote: > On Jan 26 04:45, Mike Frysinger wrote: > > These subdirs have unique configure scripts to do some compiler tests. > > The checks should work for all targets, so hoist them up to the top > > libgloss dir. This should allow us to delete these subdir configure > > scripts. >=20 > For some reason this patch doesn't apply cleanly to current git master: >=20 > Applying: libgloss: merge epiphany & libnosys & or1k configure scripts = up a level > error: git apply: bad git-diff - inconsistent old filename on line 38 > Patch failed at 0001 libgloss: merge epiphany & libnosys & or1k configu= re scripts up a level > [...] probably because the deletions were removed from the patch before posting to avoid going over the mailing list limit and make it easier to focus on the actual changes, not generated content. binutils/gdb allows devs to push to refs/heads/users/$USER/xxx. glibc allows refs/heads/$USER/xxx. should we carve out similar space here ? then i could push my branches there and it'd be easy for you to git fetch && git merge with the right state. no need to sync multiple e-mails to your local tree. > I'm a bit concerned that this patchset removes setting and AC_SUBST'ing > host_makefile_frag_path while the variable is still used by various > Makefile.in files... sorry, but what are you looking at ? it isn't deleting that setting. the top level configure script has always had (and i'm not removing): host_makefile_frag=3D${srcdir}/config/default.mh host_makefile_frag_path=3D$host_makefile_frag AC_SUBST(host_makefile_frag_path) AC_SUBST_FILE(host_makefile_frag) so when i delete libgloss/$ARCH/configure, they don't lose that setting, they simply get it from the top level configure instead of the $ARCH one. -mike --ZG5ClwI3tedzx0dY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmHyBCoACgkQQWM7n+g3 9YGRhg/+JUym7k0Rujqt8wCbE02wLiDervLpVvUEEcE+JcsfdpzChuT60pVwJNWL Fx+T3k6TfIY8WNoWkjuiJwyoMW2AnVjU0hsnnE7ypKsAEq19qcMTY49etyNaArto SKtYTXgzQZjBBf0FE0p0HKo0FwbldhfTGH2N2UognzGS5dgaEHVCV7W555Yxz66U Q8qJ2RoAuGfPGXkupXhAZKBTIRh1S8eaxE+ycEBY7G7mBKFvWIoAhW6FigV8nVCD 08c+Wn6ciZXveXhJxlD9MOHCOgdrHJG4TX+93QalT+f4iNbpLXz7KGXl+xC4+wCz vy/NjSWLlSNqRCCRIojac16kFV0dtCLVDeqK+1C/WU8bZjYmv5jSctc93rhTCohB +9n/9Kc3PhlFU5yrogtD8u3ymxve2KJycpw9uODBA9woDFBb/sRzqlH+vDJzDSvt rlYGvdznQ/gp7PcAdIdVKf3X6UxQwkeYVy2waPTxYc9ciQAgJDvCXoAwFPee9D4q 5dyEwUq/1drCQ2NMgG5dEJ3N0qE9QH4sEn/lm4Tux/Rl694ZSnL+J8rQQ0YlZEBM tKRDtgDIVqIibKSaxOTPYhi9W7fRQC56IFCbs9iO/68xI7Jw3ubmu+mNKKENYzr5 5EyPKRV6n5aCwxSrynGly2eNIPAyesNewsRI44b+LN2/CIBwrqM= =IAmK -----END PGP SIGNATURE----- --ZG5ClwI3tedzx0dY--