From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id DC6DB3858D20 for ; Thu, 27 Jan 2022 02:49:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DC6DB3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 5301334301C; Thu, 27 Jan 2022 02:49:10 +0000 (UTC) Date: Wed, 26 Jan 2022 21:49:14 -0500 From: Mike Frysinger To: newlib@sourceware.org Subject: Re: [PATCH] newlib: merge iconvdata into top-level Makefile Message-ID: Mail-Followup-To: newlib@sourceware.org References: <20220122060458.7539-1-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XIAJRPYvBiyBfslg" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jan 2022 02:49:13 -0000 --XIAJRPYvBiyBfslg Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 26 Jan 2022 13:32, Corinna Vinschen wrote: > On Jan 25 16:19, Mike Frysinger wrote: > > On 25 Jan 2022 13:27, Corinna Vinschen wrote: > > > Local.mk is neither a name speaking for itself, nor does it stand out > > > due to being one of very few files in a dir starting with uppercase, = or > > > due to its catchphrase "Make...". In terms of easy recognition for > > > people trying to wrap their head around the build system and trying to > > > find the right place to add or improve build rules, local.mk isn't > > > overly helpful. > > >=20 > > > The *.mk files in Free/Open/NetBSD are not just called local.mk and a= re > > > spread out over all the subdirs. Most of these files are in the sys/= conf > > > and /share/mk dirs and have a speaking name like kern.opts.mk, etc. > > >=20 > > > In the core kernel and lib subdirs all BSDs use files called Makefile= =2Einc, > > > actually. > > >=20 > > > Therefore I would prefer Makefile.inc, too, as name for the Makefile > > > snippets in our various subdirs, if you don't mind. > >=20 > > "local" is communicating that this is make code local to this directory. > > ".mk" is communicating that this is a small make fragment/module. taken > > together, they say this is a local make fragment/module for this dir. > >=20 > > Makefile.inc is a bad name and deviates from what all other GNU/toolcha= in > > projects are adopting. i don't think newlib should be "innovating" her= e. > >=20 > > that said, i'm not the newlib maintainer, and if the newlib maintainer(= s) > > want to make "Makefile.inc" a hard requirement and not approve commits > > using "local.mk", then that's the answer. i disagree, but i don't get > > the final say. >=20 > Either Makefile.inc, or create a newlib/config dir, move the .mk files > there and give them names matching their subdir (preferred) or task. creating a parallel tree of .mk files disconnected from the source files they're responsible for enumerating is objectively worse by all metrics. i'll respin the patches with the bad "Makefile.inc" name you require. -mike --XIAJRPYvBiyBfslg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmHyCCoACgkQQWM7n+g3 9YEgqBAAinosEtDehWgfTimsInekTZ7XrZb9bskDigBvV8zlHK4gxNjZIYv02FxR aHVBNvpmqxvdtYM4guPtS/OywMJD22X9Jg7BFS7VvMLJKuN/JgcPr2bmCenI3PPw vvLZ2/acR96bmFl6+J+K/2xM6yrmmzMryfb2D3X9JUFjHBnX2GyXYMc0lTXD/5/o 4AGcDkwaOXu0QiAtucTRLvA0icClvL/b11oCKcPgXKuAPUkIt6lZy8aw6dfWQUky g2RACa6X6dcVKH1VMb7UKMSZC236T+0BwL+5Iv9nrqGeTy7JjdfW+xK2l/n0SFeM z7LaKch/grgHStcSvvZ5omPCWNVKvC/BlOdJ0tgAQGdJ7Wpk6DTR00D7rBO9920z l/rzM8l9NGKomPJBrXUsdtuBCAh+JNiGV8d1gJJ48tPMokOT5Z2KRszChaa3Lac8 JDfZGGJDjC9TcYBjNRu7wo6vmKGvief6xmzPnxm2gKP7tpFbKyXkRlSE+P1gvxpP rSwT34n9OChlHmn/1gskAIWUcjcvxH8I1vQ441DtOfV5LswLrgLUVqjjDqgF5vfy NyvPSJb6AaFeTri72JJYhBz2nyTbhbKQrgw6hJvbrflQ2hC//z2qJryYF7neU6md 6eIfvla/N6QlcH35jhoC744+P7E6ldFQlqPzadWMK842N3gwEgs= =3o4A -----END PGP SIGNATURE----- --XIAJRPYvBiyBfslg--