From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2949B3948488 for ; Thu, 27 Jan 2022 14:45:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2949B3948488 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643294707; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=lZFSVJtaOsOBWuXqwy/SXsscF5cmKc8a3OgUYnQnlDo=; b=M1F0VOnUVlDa95qTIhW7VmBCQmI7TSg2+GRvs+aAmUCa3cb4RVpsyodu8gxNo7Mzw8lFZ1 l6Na7L4R2+Ra+8T5u3FeAfr9XWggtUIau51nz8aQzhOh2QeSuskVDtWIlYSJFwHXw+yC9y ZHHAxHHX+QQXgoUQQ6Sev/Fb3ktWoC8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-444-G2UpQeIyMuS_Yx_YBBVOYw-1; Thu, 27 Jan 2022 09:45:03 -0500 X-MC-Unique: G2UpQeIyMuS_Yx_YBBVOYw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 428CD2F45 for ; Thu, 27 Jan 2022 14:45:02 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-112-15.ams2.redhat.com [10.36.112.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 136F770398 for ; Thu, 27 Jan 2022 14:45:02 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 6B6ABA80887; Thu, 27 Jan 2022 15:45:00 +0100 (CET) Date: Thu, 27 Jan 2022 15:45:00 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH 1/3] libgloss: merge epiphany & libnosys & or1k configure scripts up a level Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220126094508.24259-1-vapier@gentoo.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jan 2022 14:45:09 -0000 On Jan 26 21:32, Mike Frysinger wrote: > On 26 Jan 2022 13:30, Corinna Vinschen wrote: > > On Jan 26 04:45, Mike Frysinger wrote: > > > These subdirs have unique configure scripts to do some compiler tests. > > > The checks should work for all targets, so hoist them up to the top > > > libgloss dir. This should allow us to delete these subdir configure > > > scripts. > > > > For some reason this patch doesn't apply cleanly to current git master: > > > > Applying: libgloss: merge epiphany & libnosys & or1k configure scripts up a level > > error: git apply: bad git-diff - inconsistent old filename on line 38 > > Patch failed at 0001 libgloss: merge epiphany & libnosys & or1k configure scripts up a level > > [...] > > probably because the deletions were removed from the patch before posting > to avoid going over the mailing list limit and make it easier to focus on > the actual changes, not generated content. > > binutils/gdb allows devs to push to refs/heads/users/$USER/xxx. glibc > allows refs/heads/$USER/xxx. should we carve out similar space here ? > then i could push my branches there and it'd be easy for you to git > fetch && git merge with the right state. no need to sync multiple > e-mails to your local tree. > > > I'm a bit concerned that this patchset removes setting and AC_SUBST'ing > > host_makefile_frag_path while the variable is still used by various > > Makefile.in files... > > sorry, but what are you looking at ? it isn't deleting that setting. > the top level configure script has always had (and i'm not removing): > host_makefile_frag=${srcdir}/config/default.mh > host_makefile_frag_path=$host_makefile_frag > AC_SUBST(host_makefile_frag_path) > AC_SUBST_FILE(host_makefile_frag) > > so when i delete libgloss/$ARCH/configure, they don't lose that setting, > they simply get it from the top level configure instead of the $ARCH one. > -mike Ok, please push. Thanks, Corinna