From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by sourceware.org (Postfix) with ESMTPS id DA5CC3858D28 for ; Fri, 28 Jan 2022 23:32:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DA5CC3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x530.google.com with SMTP id p125so6596769pga.2 for ; Fri, 28 Jan 2022 15:32:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=CY3rQK0gR8NhQR7qdzoa1cJOp5kiDHCm3Sn+VD4gRMs=; b=YdPo5sL8E+YQ4YXdtEuZaq/hVNqUYN3PDbEWnvPlSDu0HisJhHzEesT/1dehaB6TCf siXzOVB/1Qucm/SlR8lmW55c6k4zf1Wcv5s241pqYAsmcW1SrfMWNXwRxfBRz6XnBA1W C7jujFozsFAOMu463NUogoJ7KZeaHj4RJCCSh04iNp+xCyEgdxm4FXyelBPuOyfzlHKi fAQmZQdFAELocDS/LpcaoeKRs39Z7oJPFsuHNMcHxe6O+cXvF4y1QYMZx5+zoeX5CAEh SOHjeuydaSsw31OuEv5omWG4MhxAB+oUY5qADSzDUFa8LiRnXsFhzydgqu+1oiEXVGZM D96g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=CY3rQK0gR8NhQR7qdzoa1cJOp5kiDHCm3Sn+VD4gRMs=; b=o+h2eHjunOR/CcVWRK/ozJtpqWf88fOAQIWsG/KXD+K2+j2G8nzePzDM4bctJS+LQJ uwuipMJL0HPU1nyTlio5bh5tVVEfiJdMUgHrSN+LvGXYnzfK9qaxuTDQJhrofaCFOwcc dKnnEAnGUg6WBajM3O82TsDPey1gut3DemR0qc3os7KYVzJeLYPE+rOmrzPTnfxuyQAA NjNJPZnvzbLGlH7JhCJK27uOs5u7H+q7Zwq44MDOzzu7EblRF0OzLqKKgc30NkJAVbxM odp4pMqqqce21OVtRPS9jSuJbverxwCMIk+fx4saRElCBRzEfO3wW1X+JUSMOPSNHFDy juFA== X-Gm-Message-State: AOAM531n3HDqC+MpJyWr1bOyssth0JDwRVjLVIHIz3Zjir12uvzJBVcA Xro8iE4dkf9pOfFhietjd58= X-Google-Smtp-Source: ABdhPJza9lsBQl4jc3VkZ5qf9p6AlcrgiYwIqXbzYV6ZPTbXGK3DRMHI0dNJhENAw/trhTL7+31V+w== X-Received: by 2002:a63:2a45:: with SMTP id q66mr8215984pgq.484.1643412761969; Fri, 28 Jan 2022 15:32:41 -0800 (PST) Received: from localhost ([2409:10:24a0:4700:e8ad:216a:2a9d:6d0c]) by smtp.gmail.com with ESMTPSA id qe12sm3384628pjb.14.2022.01.28.15.32.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jan 2022 15:32:40 -0800 (PST) Date: Sat, 29 Jan 2022 08:32:39 +0900 From: Stafford Horne To: Jeff Law Cc: Mike Frysinger , newlib@sourceware.org Subject: Re: nds broken by recent patches Message-ID: References: <171dc9cb-6b2c-ead3-1c55-27fadb33220f@gmail.com> <3da42247-9096-0a03-4b38-66460854c2c7@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jan 2022 23:32:44 -0000 On Fri, Jan 28, 2022 at 02:54:24PM -0700, Jeff Law wrote: > Replying to myself... > > On 1/28/2022 9:36 AM, Jeff Law wrote: > > > > For example, someone mucked up the compiler for or1k-elf at the same > > time you're doing your refactoring.  Now I've got a patch to fix the > > compiler ICE, *but* I'm also getting a crap-ton of new testsuite > > failures in the testsuite due to missing _init/_fini symbols.  I don't > > know yet if that's a newlib issue or something else mucked up on the > > compiler side. > I think I've tracked this done.  The change to internalize > HAVE_INITFINI_ARRAY wasn't complete.  It missed newlib.  Affects aarch64, > arm, or1k and cris -elf ports.  I don't test for former pair, but I do test > the latter pair.   or1k and cris fail differently. or1k-elf code fails to > link, while cris-elf fails a few tests that rely on ctor/dtor support. Is there anything I can help with here for or1k-elf? Or was this something I did wrong with ff7b7b894 ("libgloss: or1k: If available call the init for init_array")? I haven't rebuilt my newlib toolchain since last year or so. -Stafford