From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id EAF853858D28 for ; Sat, 29 Jan 2022 05:15:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EAF853858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 92E5F342CD3; Sat, 29 Jan 2022 05:15:10 +0000 (UTC) Date: Sat, 29 Jan 2022 00:15:15 -0500 From: Mike Frysinger To: Jeff Law Cc: newlib@sourceware.org Subject: Re: nds broken by recent patches Message-ID: Mail-Followup-To: Jeff Law , newlib@sourceware.org References: <171dc9cb-6b2c-ead3-1c55-27fadb33220f@gmail.com> <3da42247-9096-0a03-4b38-66460854c2c7@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ne4uzQ38rqeLBEdl" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Jan 2022 05:15:11 -0000 --Ne4uzQ38rqeLBEdl Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 28 Jan 2022 14:54, Jeff Law wrote: > On 1/28/2022 9:36 AM, Jeff Law wrote: > > For example, someone mucked up the compiler for or1k-elf at the same=20 > > time you're doing your refactoring.=C2=A0 Now I've got a patch to fix t= he=20 > > compiler ICE, *but* I'm also getting a crap-ton of new testsuite=20 > > failures in the testsuite due to missing _init/_fini symbols.=C2=A0 I d= on't=20 > > know yet if that's a newlib issue or something else mucked up on the=20 > > compiler side. >=20 > I think I've tracked this done.=C2=A0 The change to internalize=20 > HAVE_INITFINI_ARRAY wasn't complete.=C2=A0 It missed newlib.=C2=A0 Affect= s=20 > aarch64, arm, or1k and cris -elf ports.=C2=A0 I don't test for former pai= r,=20 > but I do test the latter pair.=C2=A0=C2=A0 or1k and cris fail differently= =2E=20 > or1k-elf code fails to link, while cris-elf fails a few tests that rely= =20 > on ctor/dtor support. thanks ... the expectation was that things outside of newlib weren't relying on this, but i think it's prob OK for libgloss to. not great, but not entirely unreasonable. not sure what you meant by "it missed newlib" as your fix only touches libgloss. assuming that was a thinko. -mike --Ne4uzQ38rqeLBEdl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmH0zWMACgkQQWM7n+g3 9YHd0RAAyIupM0SWBzPWJMAYqH2vbDmd7lI85aHIEeWzDGOshGzSzbjcB9VogWbO 5jxVQt1z5Wn1KH8lG1kcJsggxU5juUVJKwONBpDXpK3F88+mMkj+UNNI8P8z7r6U 7NYeoRhUq3v4sqWiquasTcZtXesEZKztRMp2JoXW4PJ8W/w4iEVutTTQ0R/wFpmo pdod3o3oWtjHv4JeEydtIqCSKS3TNjQH99R3R4Pc4Jvqt1IE6rpZYAvPZumud6Q1 2fIszAWWy6Ajt2rFO3R8s09xjo9Fq2ui6H4g11IEdzC57pMoBT3H3pRuuwhdZNm0 J/Eo0u1HFJ61Yw3Nt802j7lFmPT0iG96YESB1agQNOY1ycqDjbfulPrqS4o9cKlX PRsWSBVVnKgJTKyFjsXSRQpDH8qZALHZcTAT8DdCIAjpRNwWAPBUDPcUiYngDJZ/ +jFws/PUOk92PQmndnNNl79dHN/qjppeKtkGumVRLVmRhXOc/OD7ZLKVPVNCzdZe FRox6i1e63RuqOenOd5AW7WsWBhSyfFgFEWKAOhKHVB58DmzFXaU5TJi4kY9EjpD mTRSQVFKmxp66ybaXcYW0Dicfn/avk0Uno1eLe4WfiyoVPpcInDFfces5T/xxEyn i0ExbDdPQEIkV7i1i+4LKk7vsV5RqIgvzF24xjhFeckqjyNunto= =NuWM -----END PGP SIGNATURE----- --Ne4uzQ38rqeLBEdl--