From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id A8E5D3858C20 for ; Mon, 31 Jan 2022 14:18:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A8E5D3858C20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643638712; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=DprjMP+21mhKJnNB6h/dC7bJjE1s74zitVjA6Y53vDk=; b=d0O/aCBG0TMeEgL9smq+1OeyjIzFIn5NDLzS0zeI8Jit177tjvv/0kNvKS1uQ5gbXLxPGh G440jceCXApnI/Gfy341kT91WYIwQAeZ9O1S8pU0qJc5PIjfiEA7pfsEMQ29b6p1VEephy mtCkZDLYq6K+yHyAofOf+CiqKdQeLJg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-648-cAu3_Nx3OAaAgADUi84JDw-1; Mon, 31 Jan 2022 09:18:31 -0500 X-MC-Unique: cAu3_Nx3OAaAgADUi84JDw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6894D81440B for ; Mon, 31 Jan 2022 14:18:30 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-112-15.ams2.redhat.com [10.36.112.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3909E78A91 for ; Mon, 31 Jan 2022 14:18:30 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id E17BAA80884; Mon, 31 Jan 2022 15:18:28 +0100 (CET) Date: Mon, 31 Jan 2022 15:18:28 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH 1/2] newlib: fix preprocessor checks Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <171dc9cb-6b2c-ead3-1c55-27fadb33220f@gmail.com> <20220128102355.10213-1-vapier@gentoo.org> MIME-Version: 1.0 In-Reply-To: <20220128102355.10213-1-vapier@gentoo.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jan 2022 14:18:37 -0000 On Jan 28 05:23, Mike Frysinger wrote: > Restore the call to AC_NO_EXECUTABLES -- I naively assumed in commit > 2e9aa5f56cc26a411014a7f788423c670cfb5646 ("newlib: update preprocessor > configure checks") that checking for a preprocessor would not involve > linking code. Unfortunately, autoconf will implicitly check that the > compiler "works" before allowing it to be used, and that involves a > link test, and that fails because newlib provides the C library which > is needed to pass a link test. > > There is some code in NEWLIB_CONFIGURE specifically to help mitigate > these, but it's not kicking in here for some reason, so let's just add > the AC_NO_EXECUTABLES call back until we can unwind that custom logic. > > Additionally, we have to call AC_PROG_CPP explicitly. This was being > invoked later on, but only in the use_libtool=yes codepath, and that > is almost never enabled. > --- > newlib/libc/configure | 1206 +++++++++++++++++++++----------------- > newlib/libc/configure.ac | 2 + > newlib/libm/configure | 1128 +++++++++++++++++++---------------- > newlib/libm/configure.ac | 2 + > 4 files changed, 1285 insertions(+), 1053 deletions(-) LGTM Thanks, Corinna