From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 937B73858D20 for ; Tue, 1 Feb 2022 04:49:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 937B73858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 0B0A0343464; Tue, 1 Feb 2022 04:49:35 +0000 (UTC) Date: Mon, 31 Jan 2022 23:49:34 -0500 From: Mike Frysinger To: Richard Earnshaw , Jeff Johnston Cc: newlib@sourceware.org Subject: arm-eabi fails in libc/sys/arm/: No rule to make target 'lib_a-trap.o', needed by 'lib.a'. Message-ID: Mail-Followup-To: Richard Earnshaw , Jeff Johnston , newlib@sourceware.org References: <20220123060429.16293-1-vapier@gentoo.org> <20220123060429.16293-7-vapier@gentoo.org> <12f1a3b1-7832-6762-4cea-634bd17c268c@foss.arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LInHgh/yfGSHhvxH" Content-Disposition: inline In-Reply-To: <12f1a3b1-7832-6762-4cea-634bd17c268c@foss.arm.com> X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Feb 2022 04:49:38 -0000 --LInHgh/yfGSHhvxH Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 31 Jan 2022 16:08, Richard Earnshaw wrote: > This patch seems to have broken arm newlib builds (at least, when not=20 > using libgloss). I'm seeing: >=20 > make[5]: Entering directory=20 > '/work/rearnsha/scratch/nightly/arm/master/arm-eabi/ > newlib/libc/sys/arm' > CC lib_a-access.o > CC lib_a-aeabi_atexit.o > make[5]: *** No rule to make target 'lib_a-trap.o', needed by 'lib.a'. St= op. >=20 > And indeed, the Makefile in that directory now lacks anything to build=20 > lib_a-trap.o from trap.S. Something explicit is needed because of the=20 > non-standard file rename that we use. this patch series is unrelated. this is due to a previous patch of mine: newlib: delete (most) redundant lib_a_CCASFLAGS=3D$(AM_CCASFLAGS) this is because i think newlib was relying on automake behavior that is undocumented or unintended. that said, i'm not sure why this Makefile.am is written the way it is. it'd be a lot simpler like: --- a/newlib/libc/sys/arm/Makefile.am +++ b/newlib/libc/sys/arm/Makefile.am @@ -6,16 +6,10 @@ AM_CCASFLAGS =3D $(AM_CPPFLAGS) =20 noinst_LIBRARIES =3D lib.a =20 +lib_a_SOURCES =3D access.c aeabi_atexit.c if MAY_SUPPLY_SYSCALLS -extra_objs =3D $(lpfx)libcfunc.o $(lpfx)trap.o $(lpfx)syscalls.o -else -extra_objs =3D +lib_a_SOURCES +=3D libcfunc.c trap.S syscalls.c endif - -lib_a_SOURCES =3D access.c aeabi_atexit.c -lib_a_LIBADD =3D $(extra_objs) -EXTRA_lib_a_SOURCES =3D trap.S syscalls.c libcfunc.c -lib_a_DEPENDENCIES =3D $(extra_objs) lib_a_CFLAGS =3D $(AM_CFLAGS) =20 if MAY_SUPPLY_SYSCALLS maybe Jeff can remember why it was written this way since it comes from: commit 313f13497935d2831e76f9b8b61ccc762dc1cc65 Author: Jeff Johnston Date: Sat Feb 8 04:30:58 2003 +0000 2003-02-07 Jeff Johnston * acinclude.m4 (--disable-newlib-supplied-syscalls): New config= uration option to allow disabling of syscalls being supplied in newlib. * aclocal.m4: Regenerated. * configure: Ditto. * configure.host: Add support of new configuration option and a= dd -D__NO_SYSCALLS__ if newlib supplied syscalls are disabled. * doc/aclocal.m4: Regenerated. * doc/configure: Ditto. * libc/*aclocal.m4: Ditto. * libc/*configure: Ditto. * libm/*aclocal.m4: Ditto. * libm/*configure: Ditto. * libc/sys/arm/Makefile.am: Don't build syscalls.o if new option is disabled. -mike --LInHgh/yfGSHhvxH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmH4u94ACgkQQWM7n+g3 9YFsjBAA0FUz+0xm8urAgpF8GNbu+VIfmIiepZA4dewz+Izwnd3KNT9y2iAa2B4f /mCvM2iKbqgao4I2nU/93TL4KAAgDVTwnkVPZ/6XFSIZgc6pGulVWNXr1HCWmDog EZL2WOEsvn6dEotIHBIConGR97wbXKTcMPuoQ09B8n4B8eWDGF3384KOIinsybm5 0QnFn+fS0Jzvn5cjiAuQhD2fTOtkePj+sutJZVwicT0NHq7bm25KLIymXpHV3ADw NXdFIdiQDK7FF436EA3t103+xyMGvDBVDeOEKcFMzogKHNVsIdytkcfeXBe84Hhr 4+Wm9yTE0Cp+oD3H9wyvynrvuKxH4y7nm+ct1XZAmaUZsDySN3JEY3NwiwOjDl21 vB5UBp1vx2j558i048xphTrcia//HkzbJ/GeAgimegbRNPogp+kK920jWL2CovIl XMDNGtQVW08oRF4i/LvPaaawZE8xSXAOU/WqVpXB7kNO2s6o68MCeBlXsOXTNr+x BvyneYmc4pzfBRgPVOXhRLSVz4VjZRbMLwyP//0D2YGHPg5ihUXDo5fB25/ThSxe psxDIZU0Fggff8lwZjHiUSdMDK9BazOB1yXOF5SIN9i7DMjjZlUwCmR6NfFzWGG0 4r9xPc7HSCLqwFkP3yWPuGSEtFVoWamu2LqaEA5myjJVNP0mvgw= =vBB4 -----END PGP SIGNATURE----- --LInHgh/yfGSHhvxH--