From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id DE1253858D35 for ; Tue, 1 Feb 2022 03:10:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DE1253858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id C24293431DF; Tue, 1 Feb 2022 03:10:26 +0000 (UTC) Date: Mon, 31 Jan 2022 22:10:25 -0500 From: Mike Frysinger To: newlib@sourceware.org Subject: Re: [PATCH 1/3] newlib: export abs_newlib_basedir for all subdirs Message-ID: Mail-Followup-To: newlib@sourceware.org References: <20220128003316.22356-1-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="q3AKGcFV47xsqfly" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Feb 2022 03:10:29 -0000 --q3AKGcFV47xsqfly Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 31 Jan 2022 14:16, Corinna Vinschen wrote: > On Jan 27 19:33, Mike Frysinger wrote: > > When using the top-level configure script but subdir Makefiles, the > > newlib_basedir value gets a bit out of sync: it's relative to where > > configure lives, not where the Makefile lives. Move the abs setting > > from the top-level configure script into acinclude.m4 so we can rely > > on it being available everywhere. Although this commit doesn't use > > it anywhere, just lays the groundwork. >=20 > Patchset looks ok to me. Would you mind to send patchsets consisting > of more than a single patch with a cover-letter? It's just easier > to discusss the entire patchset vs. discussing single patches. sure, if you prefer -mike --q3AKGcFV47xsqfly Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmH4pKEACgkQQWM7n+g3 9YFD8w//b9DRtXV7pAkG1ijh442blzgVqBTsGYuOqlHeST4zGEvbq5GRRIvNayzj bNjlffMFWS2B/PG6QZ/IGu+PqRUHAR1sNWS5BhGfuEHIAPqzZDLUT5D8MjeWSDc0 IG4QK1vJUuu7E9OmFDYMbLX97mcz3x3BmS9u5hWyezumw9UhwXH7u1LMueqbBeMh dif4pfZWzO6Nyj8nZ67HZLYwKz5AOxUPxwyD29ymCdfOOFdkcjjZubYUmERO0Lfs FDoAM5q0nvPtK/bzaEeX4J2q7o2Tn+Sgm22kfC4RDiNfm6VDeq6kdHQLnEDu1p9g MpSQFtpQprtXjA9Yz06VfGX/HDIp9+RzSeF2TlPgR4HGTL83J3GtfxscdHf/X3Ow HAUYhztqBg7aD8xPKas/PKBx7BypkxLIO4FD0l/FrjYMr41tmMrTx8/KyIpEIQvu awADbURfg8T3dT8k68xETF7GLn0PEeCpCnF+7oFsQrVXHSnbtnYXkOzOG1atqlzC ZGhBLxaBhzyG+OIvM7lnhVY5F0X15kUkaC+ManlplB1FBwK7ZOa1w76GFqN1C8k6 TLkfuPpBz9AVRyLQ5EDBdUlytnbdasK8wT36WeWPulqTT0cymqcSM3P9a9+wGOk+ GtEYoiD1D293lWxZFThClk0VXYt4EY8rf8pgpKkhoA5O3axleMw= =X13m -----END PGP SIGNATURE----- --q3AKGcFV47xsqfly--