public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: newlib@sourceware.org
Subject: Re: newlib_cv_ vs libc_cv_ autoconf cache vars prefix
Date: Mon, 31 Jan 2022 22:12:31 -0500	[thread overview]
Message-ID: <YfilH20Jc4Ddwo9D@vapier> (raw)
In-Reply-To: <YffvXZq8mey16dTL@calimero.vinschen.de>

[-- Attachment #1: Type: text/plain, Size: 1152 bytes --]

On 31 Jan 2022 15:17, Corinna Vinschen wrote:
> On Jan 28 04:44, Mike Frysinger wrote:
> > the newlib/libgloss configure scripts use both libc_cv_ and newlib_cv_ as
> > their autoconf cache var prefixes.  this really should be just one name.
> > i'm inclined to use newlib_cv_ rather than the more generic libc_cv_.  any
> > preferences or reasons to pick one or the other ?
> > 
> > libgloss also has cache vars.  i'm inclined to have it use newlib_cv_ too
> > since, as a project, it's carved out the namespace, and doesn't really need
> > its own libgloss_cv_ prefix.
> 
> AFAICS, only six libc_cv_* and two newlib_cv_* vars exist at all, and only
> two of the libc_cv_* vars are AC_SUBST'ed and show up in the Makefile.
> Using the same prefix for all vars, it would be the smaller change to
> switch the 2 newlib_cv's to libc_cv.  The result would be the same.

the reason i'm not a fan of libc_cv is that glibc uses that namespace.  if you
want to setup a config.site cache for a target that builds glibc & newlib, then
it's hard to avoid namespace conflicts.  but if we use newlib_cv_, then there's
no such collision.
-mike

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2022-02-01  3:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-28  9:44 Mike Frysinger
2022-01-31 14:17 ` Corinna Vinschen
2022-02-01  3:12   ` Mike Frysinger [this message]
2022-02-01 14:55     ` Corinna Vinschen
2022-02-02  2:52 ` [PATCH 1/2] newlib: drop unused cache vars from Makefiles Mike Frysinger
2022-02-02  2:52   ` [PATCH 2/2] newlib: rename libc_cv_ prefix to newlib_cv_ Mike Frysinger
2022-02-03 12:08   ` [PATCH 1/2] newlib: drop unused cache vars from Makefiles Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YfilH20Jc4Ddwo9D@vapier \
    --to=vapier@gentoo.org \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).