From: Mike Frysinger <vapier@gentoo.org>
To: Jon Turney <jon.turney@dronecode.org.uk>
Cc: "newlib@sourceware.org" <newlib@sourceware.org>
Subject: Re: [PATCH 1/5 v2] newlib: libm: move manual into top-level build
Date: Mon, 31 Jan 2022 22:40:06 -0500 [thread overview]
Message-ID: <Yfirlr4FYpUPuBB2@vapier> (raw)
In-Reply-To: <bfe04a31-fee4-3da6-cd54-54c1d4d68674@dronecode.org.uk>
[-- Attachment #1: Type: text/plain, Size: 1939 bytes --]
On 31 Jan 2022 14:58, Jon Turney wrote:
> On 28/01/2022 07:58, Mike Frysinger wrote:
> > --- /dev/null
> > +++ b/newlib/libm/Makefile.inc
> > @@ -0,0 +1,26 @@
> > +info_TEXINFOS += %D%/libm.texi
> > +%C%_libm_TEXINFOS = %D%/targetdep.tex $(LIBM_CHEWOUT_FILES)
> > +
> > +LIBM_CHEWOUT_FILES =
> > +
> > +LIBM_CHAPTERS =
> > +
> > +%D%/libm.dvi: %D%/targetdep.tex $(LIBM_CHEWOUT_FILES)
> > +
> > +%D%/targetdep.tex: $(LIBM_CHAPTERS)
> > + $(AM_V_GEN)cat $^ > $@.tmp
> > + $(AM_V_at)$(SHELL) $(newlib_basedir)/../move-if-change $@.tmp $@
> > + $(AM_V_at)touch $@
>
> We carefully only update $@ if it's changed, then touch it anyhow?
>
> This seems like a transcription error, since originally we were touching
> a timestamp file, or perhaps leftover from testing?
you're right of course. i saw other places that weren't using the stamp
idiom, and then when rewriting these rules i remembered those places and
thought i wouldn't bother deploying the stamp pattern here since it was
already doing it wrong. but i misremembered which ones were wrong.
> The same pattern occurs later, as well.
which one do you mean ? the .xml ones ? those currently aren't using the
stamp idiom. or do you just mean the multiple places where targetdep.tex
is generated ?
> > --- a/newlib/libm/common/Makefile.am
> > +++ b/newlib/libm/common/Makefile.am
> >
> > -CHAPTERS =
> > +LIBM_CHEWOUT_FILES =
> > +LIBM_CHAPTERS =
> > +include ./Makefile.inc
>
> Is this boilerplate really needed before including the makefile
> fragment, since '+=' should work even if the variable isn't already defined?
yes, automake enforces it
ideally we'll kill all libm/*/Makefile.am files at which point this boiler
plate isn't needed since there will just be the one set in the top-level
libm/Makefile.am. i'm holding off on doing that clean up until i can finish
landing my current batch of changes.
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-02-01 3:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-22 4:32 [PATCH 0/5] migrate documentation into top-level Mike Frysinger
2022-01-22 4:32 ` [PATCH 1/5] newlib: libm: move manual into top-level build Mike Frysinger
2022-01-22 4:32 ` [PATCH 2/5] newlib: libc: include all chapters all the time in the manual Mike Frysinger
2022-01-22 4:32 ` [PATCH 3/5] newlib: libc: move manual into top-level build Mike Frysinger
2022-01-24 14:30 ` Corinna Vinschen
2022-01-22 4:32 ` [PATCH 4/5] newlib: move man page generation " Mike Frysinger
2022-01-22 4:32 ` [PATCH 5/5] newlib: drop shared documentation rules Mike Frysinger
2022-01-28 7:58 ` [PATCH 1/5 v2] newlib: libm: move manual into top-level build Mike Frysinger
2022-01-28 7:58 ` [PATCH 2/5 v2] newlib: libc: include all chapters all the time in the manual Mike Frysinger
2022-01-28 7:58 ` [PATCH 3/5 v2] newlib: libc: move manual into top-level build Mike Frysinger
2022-01-28 7:58 ` [PATCH 4/5 v2] newlib: move man page generation " Mike Frysinger
2022-01-28 7:58 ` [PATCH 5/5 v2] newlib: drop shared documentation rules Mike Frysinger
2022-01-31 14:58 ` [PATCH 1/5 v2] newlib: libm: move manual into top-level build Jon Turney
2022-02-01 3:40 ` Mike Frysinger [this message]
2022-02-01 14:37 ` Jon Turney
2022-02-01 6:21 ` [PATCH 1/5 v3] " Mike Frysinger
2022-02-01 6:21 ` [PATCH 2/5 v3] newlib: libc: include all chapters all the time in the manual Mike Frysinger
2022-02-01 6:21 ` [PATCH 3/5 v3] newlib: libc: move manual into top-level build Mike Frysinger
2022-02-01 6:21 ` [PATCH 4/5 v3] newlib: move man page generation " Mike Frysinger
2022-02-01 14:37 ` Jon Turney
2022-02-01 23:12 ` Mike Frysinger
2022-02-01 6:21 ` [PATCH 5/5 v3] newlib: drop shared documentation rules Mike Frysinger
2022-02-05 12:13 ` [PATCH 1/5 v3] newlib: libm: move manual into top-level build Corinna Vinschen
2022-02-05 18:04 ` Mike Frysinger
2022-02-07 10:30 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yfirlr4FYpUPuBB2@vapier \
--to=vapier@gentoo.org \
--cc=jon.turney@dronecode.org.uk \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).