From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id EC22B3858C2D for ; Tue, 1 Feb 2022 14:56:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EC22B3858C2D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643727391; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=KoEeqVf/rKPwfny2pgHIaNQUGFZqWCQqFdwLabXEd/Y=; b=VHBEVJqnJw/g9xgefDnT5x2XvDd71qjbbApg3LQsv2bIAxQTq/gpmRyjEzAsm2bjNmDaOW z7Y32XNdKKwIhvl4olB/X087C3+6ECRVxOg9Ih6ycGwwGAh1Z57OglTRLJmYqL8/mMQrHC F9L+OGDD/bXnbiwVMZlHSusv8eClMOE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-185-QVxbtA6qPF-4Eo80ufs2KQ-1; Tue, 01 Feb 2022 09:55:47 -0500 X-MC-Unique: QVxbtA6qPF-4Eo80ufs2KQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E9DE31091DA1 for ; Tue, 1 Feb 2022 14:55:46 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-112-15.ams2.redhat.com [10.36.112.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9CCFE7DE39 for ; Tue, 1 Feb 2022 14:55:46 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id F055FA80884; Tue, 1 Feb 2022 15:55:44 +0100 (CET) Date: Tue, 1 Feb 2022 15:55:44 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: newlib_cv_ vs libc_cv_ autoconf cache vars prefix Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, PDS_OTHER_BAD_TLD, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Feb 2022 14:56:33 -0000 On Jan 31 22:12, Mike Frysinger wrote: > On 31 Jan 2022 15:17, Corinna Vinschen wrote: > > On Jan 28 04:44, Mike Frysinger wrote: > > > the newlib/libgloss configure scripts use both libc_cv_ and newlib_cv_ as > > > their autoconf cache var prefixes. this really should be just one name. > > > i'm inclined to use newlib_cv_ rather than the more generic libc_cv_. any > > > preferences or reasons to pick one or the other ? > > > > > > libgloss also has cache vars. i'm inclined to have it use newlib_cv_ too > > > since, as a project, it's carved out the namespace, and doesn't really need > > > its own libgloss_cv_ prefix. > > > > AFAICS, only six libc_cv_* and two newlib_cv_* vars exist at all, and only > > two of the libc_cv_* vars are AC_SUBST'ed and show up in the Makefile. > > Using the same prefix for all vars, it would be the smaller change to > > switch the 2 newlib_cv's to libc_cv. The result would be the same. > > the reason i'm not a fan of libc_cv is that glibc uses that namespace. if you > want to setup a config.site cache for a target that builds glibc & newlib, then > it's hard to avoid namespace conflicts. but if we use newlib_cv_, then there's > no such collision. > -mike Good point. Feel free to make the change. Corinna