From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 6D0953858D20 for ; Fri, 4 Feb 2022 01:44:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6D0953858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id C4B04343354; Fri, 4 Feb 2022 01:44:16 +0000 (UTC) Date: Thu, 3 Feb 2022 20:44:16 -0500 From: Mike Frysinger To: Richard Earnshaw Cc: Jeff Johnston , newlib@sourceware.org Subject: Re: arm-eabi fails in libc/sys/arm/: No rule to make target 'lib_a-trap.o', needed by 'lib.a'. Message-ID: Mail-Followup-To: Richard Earnshaw , Jeff Johnston , newlib@sourceware.org References: <20220123060429.16293-1-vapier@gentoo.org> <20220123060429.16293-7-vapier@gentoo.org> <12f1a3b1-7832-6762-4cea-634bd17c268c@foss.arm.com> <1a230e3b-345b-da24-2954-d7daf2a87d26@foss.arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jTXtyv1g4dwHjLYj" Content-Disposition: inline In-Reply-To: <1a230e3b-345b-da24-2954-d7daf2a87d26@foss.arm.com> X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Feb 2022 01:44:19 -0000 --jTXtyv1g4dwHjLYj Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 03 Feb 2022 16:49, Richard Earnshaw wrote: > On 01/02/2022 04:49, Mike Frysinger wrote: > > this is because i think newlib was relying on automake behavior that is > > undocumented or unintended. that said, i'm not sure why this Makefile.= am > > is written the way it is. it'd be a lot simpler like: > >=20 > > --- a/newlib/libc/sys/arm/Makefile.am > > +++ b/newlib/libc/sys/arm/Makefile.am > > @@ -6,16 +6,10 @@ AM_CCASFLAGS =3D $(AM_CPPFLAGS) > > =20 > > noinst_LIBRARIES =3D lib.a > > =20 > > +lib_a_SOURCES =3D access.c aeabi_atexit.c > > if MAY_SUPPLY_SYSCALLS > > -extra_objs =3D $(lpfx)libcfunc.o $(lpfx)trap.o $(lpfx)syscalls.o > > -else > > -extra_objs =3D > > +lib_a_SOURCES +=3D libcfunc.c trap.S syscalls.c > > endif > > - > > -lib_a_SOURCES =3D access.c aeabi_atexit.c > > -lib_a_LIBADD =3D $(extra_objs) > > -EXTRA_lib_a_SOURCES =3D trap.S syscalls.c libcfunc.c > > -lib_a_DEPENDENCIES =3D $(extra_objs) > > lib_a_CFLAGS =3D $(AM_CFLAGS) > > =20 > > if MAY_SUPPLY_SYSCALLS >=20 > This seems to work although one small difference is that instead of=20 > building libc_a-trap.o it now builds trap.o. I'm not sure if that=20 > really matters, though. right, the .S files don't have the prefix on the filename anymore. i notic= ed that and looked through the tree and couldn't see why it would be a problem. there is one or two places where the exact object file name is used (the MATHOBJS_IN_LIBC which pulls a small number of libm objects out to copy into libc.a). i'm going to push the fix now and we can revisit if someone points out a problem with it. -mike --jTXtyv1g4dwHjLYj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmH8hPAACgkQQWM7n+g3 9YHMgRAAseGTUG82C81HRj7PXr8l4u9Gdf8kiaJSegkp/3ll268Tb1MtbJnlxMjE JLWwJCAtHOGA7pAAMhupIOOWEfR7xi1CwnEtVHHnViweVgbeL9bv9bWWBGfLd+2o rZm6l7Gp+1IyXmb1q4robjjRU1G7nZsGag9HOijVBHpsyF4bR0CVFVmjF5Pmuzbl of0jvKsZ7yDQ33nCINdBMBeoFFeuTp3gpJ35CUN1dJLdMc68jxQ4/ftDK0Bjjetq jpD4+IYZdnntAwSUsJtB8wNAsIZHSQ+a9qmetgfzv+5gL49/mJ8wzNAetyOAGTit YjdNs7HVNKh3ECSrRjlMCLTHqE0+G12ukjQ07KfodUQej1KMo2GR2rA0E589OJuA sjLRFj1BvjYUJVBnt/Yc1/7g4imYqFXAtzYzUEJP2n9x3K2htY9Ix7PLC8uMnj6s B3rtOFxcsgSDp9DFBieVS+mvSgr4Rb01nXC5DgcGb3aSLM6oxDl8iC+KpHV8mu5K kKLx8ZVUImbZcciiQ9oiAEQJ61A62SAvK4E+j4nwnj9VuOFK5WsBO89gHFlHJOy9 Q+9yraXNDVO7QaaYXblIScJfDjf6mem/+62S5NhOM1r5pLEX27JXRNHuOcHC/eMb kdanN7sMMnZLQQcApJ3yC2JUG/XR9lbpUJvrCl9yggA2sLAAoos= =2Yxe -----END PGP SIGNATURE----- --jTXtyv1g4dwHjLYj--