From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 57CC8385842F for ; Fri, 18 Feb 2022 12:41:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 57CC8385842F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645188118; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=IJ9xRNl3rdl6CmFtdm2Beitex3PzpOfYzCHhmGKJHRo=; b=IBHn3oTGtIyBbk92bY6lHO88z4Kngi0JQl92SxpG9ORXedDhgzqaT5CqU/zW6//wY4LzJZ 3xnaM0YDi8w4fBlPsBJk35C3j2rwFQBXDynG243A0HifEbEpVl36v169YGZI1bpbsig+ne FZ07fi0eTa3ncYqUhb87cVOQwbdApE4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-554-oYzg9oq5MCOevXiH5KAZuQ-1; Fri, 18 Feb 2022 07:41:57 -0500 X-MC-Unique: oYzg9oq5MCOevXiH5KAZuQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E30A41091DA0 for ; Fri, 18 Feb 2022 12:41:56 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B12707B9C5 for ; Fri, 18 Feb 2022 12:41:56 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 3240CA80D35; Fri, 18 Feb 2022 13:41:55 +0100 (CET) Date: Fri, 18 Feb 2022 13:41:55 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH v2 1/1] Make __sdidinit unused Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220218094525.8394-1-matthew.joyce@embedded-brains.de> <20220218094525.8394-2-matthew.joyce@embedded-brains.de> MIME-Version: 1.0 In-Reply-To: <20220218094525.8394-2-matthew.joyce@embedded-brains.de> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Feb 2022 12:42:00 -0000 Hi Matt, On Feb 18 10:45, Matthew Joyce wrote: > Remove dependency on __sdidinit member of struct _reent to check > object initialization. Like __sdidinit, the __cleanup member of > struct _reent is initialized in the __sinit() function. Checking > initialization against __cleanup serves the same purpose and will > reduce overhead in the __sfp() function in a follow up patch. The patch looks right now. But. What exactly are you going to do in __sfp? The reason I'm asking is that it's absolutely not clear yet which purpose this change serves. Looking at this patch, I only see that, rather than using an available flag, a pointer is now set to an invalid value -1, which looks more dangerous than what we did before. Care to explain or, even better, send the patch you have in mind? Thx, Corinna