From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id F16083858D20 for ; Thu, 17 Feb 2022 04:38:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F16083858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 7583E343104; Thu, 17 Feb 2022 04:38:45 +0000 (UTC) Date: Wed, 16 Feb 2022 23:38:43 -0500 From: Mike Frysinger To: newlib@sourceware.org Subject: Re: [HEADSUP] Re: [PATCH] newlib: libm: merge build up a directory Message-ID: Mail-Followup-To: newlib@sourceware.org References: <20220212203450.19650-1-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="G6pzIX4l7By3IgX6" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Feb 2022 04:38:48 -0000 --G6pzIX4l7By3IgX6 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 16 Feb 2022 09:50, Corinna Vinschen wrote: > On Feb 12 15:34, Mike Frysinger wrote: > > Convert all the libm/ subdir makes into the top-level Makefile. This > > allows us to build all of libm from the top Makefile without using any > > recursive make calls. This is faster and avoids the funky lib.a logic > > where we unpack subdir archives to repack into a single libm.a. The > > machine override logic is maintained though by way of Makefile include > > ordering, and source file accumulation in libm_a_SOURCES. >=20 > What targets did you test this with? testing these targets: aarch64-elf arc-elf arm-eabi bfin-elf cr16-elf cris-elf csky-elf epiphany-elf frv-elf h8300-elf i386-elf i686-pc-cygwin iq2000-elf m68k-elf microblaze-elf mips-elf mn10300-elf moxie-elf nds32le-elf or1k-elf powerpc-elf sparc-elf sparc-rtems v850e-elf visium-elf xstormy16-elf the actual testing: - build w/out the patch make install DESTDIR=3D$PWD/old.root ar t every library objdump -d every object - build w/the patch make install DESTDIR=3D$PWD/new.root ar t every library objdump -d every object run `diff -ur` on the 2 roots. they install the same set of files, and the disassembly of the objects is the same. so should be good to go. only needed about 30G to determine this :p. > > One thing to note is that this will require GNU Make because of: > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >=20 > Anybody here having a problem with that? while i couldn't find any prior usage in newlib specifically (i think all the code i looked through is portable make), libgloss def has GNUisms in at least 12 of its ports: aarch64 arm bfin cris csky m68k msp430 nios2 or1k riscv visium xstormy16 no one seems to have complained so far :). -mike --G6pzIX4l7By3IgX6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmIN0VMACgkQQWM7n+g3 9YHqKw//fRB6FO0PeyG4z5Bkw4TwUWl4Mgmn9Nb7SuI5tndS2SCjOSsxHED0T4a0 cgjl72n0CbFK85rsA4jRuFRg8Ki4QLUZrVfrvronZhd2z6y4FaN4yBDb8hVwG9VF 99WKFsUO4BHhTW7YAq67L8LjB7inTNobHg5TJCMzURBdWt6wl2vIbr6MXxMlH2jd hoLcvUIQxE4U+0+ztQQuH7hCYydfEk5jHlzBiIRxYndVl7J3UwAae/MLFA9pLp6e TJ5vJrqrq9Im62M7jW/lLXUQBeD9fIWKP93AyNmhC7TUQfmkzd0XPlIpakscq4Yd WfDOr68nJ3lugaqnVtWbKbL+7mlYAfSm8hJ0zG0peEkenun/gn8C6V92fEef87zn pmiq1Y8He0U2Ma4WazICspgbT7sZim5OaBRUbHC2kNZ4IyDxz+iAamQJ48Bh4Bu9 wvQaKOs1M2N5124ijQu/QFvkYdpC+WI9KWSswmWIkpvYacb1OovJhHXz1s/4FlE/ E6WbqTTDsc8+nvO32g30WsWPsDDayv2EyQqdNt8QU82iL4KijeqEEydIy4HUKxZL DFmuYzeAgXRpQDj9Mxjh8wgG2jUi9M+4Pl2NmgP8LpihT/Lpc37zmDt4F08wecV8 V8WReIOujHzYcMGLdhB7VgK0+z8zobk7yRHlS1HLpTe4627kUco= =dPkl -----END PGP SIGNATURE----- --G6pzIX4l7By3IgX6--