From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5F4753858431 for ; Thu, 17 Feb 2022 14:06:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5F4753858431 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645106780; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=yCMLk4wca5TbOavQQ9ABjE/2x20F3VzZIyVwxkejqnM=; b=CfNyPnexKyqcaD5lMJyGdxs2BXoGy6I+/IKSAxe0TsNbt7d0ylnC+gofzMID/XRCZgCFVj Aurv2vLWS/7rTtdTunSowxlqr7kh/eH37WTJ9e2cjnwdtEd1VyAnyiz+rsx8iHBmDvpjM9 BkcXjdK3uEUkweb1TQDSIjRVj8mHyIY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-558-ILZ5caQqOsWYeFj92Hsj9A-1; Thu, 17 Feb 2022 09:06:18 -0500 X-MC-Unique: ILZ5caQqOsWYeFj92Hsj9A-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D89C9801AA6 for ; Thu, 17 Feb 2022 14:06:17 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A83856ABBD for ; Thu, 17 Feb 2022 14:06:17 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 25A71A80722; Thu, 17 Feb 2022 15:06:16 +0100 (CET) Date: Thu, 17 Feb 2022 15:06:16 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] newlib: powerpc: switch to Automake conditionals Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220217044345.5525-1-vapier@gentoo.org> MIME-Version: 1.0 In-Reply-To: <20220217044345.5525-1-vapier@gentoo.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Feb 2022 14:06:21 -0000 On Feb 16 23:43, Mike Frysinger wrote: > Using xxx_LIBADD, xxx_DEPENDENCIES, and EXTRA_xxx_SOURCES is one way of > conditionally including files into a target. But it's meant more for the > cases where the variables added to LIBADD & DEPENDENCIES are constructed > via substitution (e.g. AC_SUBST) or other dynamic methods. With Automake > conditionals, then the much simpler form is to conditionally append to > the xxx_SOURCES variable and let Automake sort everything out. > --- > newlib/libc/machine/powerpc/Makefile.am | 62 ++++++++--------- > newlib/libc/machine/powerpc/Makefile.in | 91 +++++++++++++++---------- > 2 files changed, 81 insertions(+), 72 deletions(-) ACK, Corinna