From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D31843858D20 for ; Mon, 7 Feb 2022 11:49:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D31843858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644234561; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=K0t1b4EClRvyIAU8oWwAp3SbcDBjXBaaOfY1oXnsg5w=; b=D7/voSsvzZq2pedgVbFmfpnqmzWfRfUMosxZnOhoWEjc4MpKpXjfKx3IBlf421ee1CGd7a ZOg5xttohvQ5c74r+EwIVS4jbIsFU1ZNdnrAqG0VK6AILljXPcUbDH40Wt6hsqHIR7igCT hOTZNW+WpDnBZlaktUv+gL8bqPmY7Rc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-596-M-mO0YTTM3iOP8I5F25niQ-1; Mon, 07 Feb 2022 06:49:20 -0500 X-MC-Unique: M-mO0YTTM3iOP8I5F25niQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9FB2C100C660 for ; Mon, 7 Feb 2022 11:49:19 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-112-15.ams2.redhat.com [10.36.112.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 708742A19F for ; Mon, 7 Feb 2022 11:49:19 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id D1C8CA80774; Mon, 7 Feb 2022 12:49:17 +0100 (CET) Date: Mon, 7 Feb 2022 12:49:17 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH 3/5] libgloss: merge libgloss into top-level Makefile Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220205054656.11443-1-vapier@gentoo.org> <20220205054656.11443-4-vapier@gentoo.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Feb 2022 11:49:23 -0000 On Feb 7 06:14, Mike Frysinger wrote: > On 05 Feb 2022 00:46, Mike Frysinger wrote: > > +if CONFIG_LIBNOSYS > > +include libnosys/Makefile.inc > > +endif > > --- a/libgloss/configure.ac > > +++ b/libgloss/configure.ac > > @@ -230,10 +230,7 @@ dnl if test "${config_testsuite}" = "true"; > > dnl then AC_CONFIG_SUBDIRS([testsuite]) > > dnl fi > > > > -if test "${config_libnosys}" = "true"; then > > - AC_CONFIG_FILES([libnosys/Makefile]) > > - subdirs="$subdirs libnosys" > > -fi > > +AM_CONDITIONAL(CONFIG_LIBNOSYS, test x$config_libnosys = xtrue) > > > > LIB_AC_PROG_CC > > AS=${AS-as} > > i'm not super happy with the CONFIG_xxx naming. newlib doesn't seem to have > an existing convention for me to copy & paste. there is LIB*_MACHINE_DIR, > but those correspond to specific machine/xxx/ subdirs. > > i guess i could use the newlib pattern and name these HAVE_xxx_DIR. > -mike Just keep it as is for now, it's easier to follow. Name changes can go into another patch(set). Corinna