From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6CEE93858D1E for ; Tue, 8 Feb 2022 09:27:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6CEE93858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644312444; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=En/7ZhFFwt1E6ixVweZuynYntSMhwIOxkYpC5ukJIck=; b=JLRQqqpnRw+Wzyfawd36E87oPMKDQ5iBN4DppWGEgR9IgVqcpKyCgBiT0P0sIJ9tvFyUhU dw5nnojGiTS9jZRHp7qMJPBPtS3cIesZNc5NFwtyp38tbvSoVZAkQlQ/fVxG7x3vC/EvsI hKP7IfDf5BjRpnR0fg+QVqmCN/05Oiw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-404-WUakcmKTMwSExA6jFEhz4Q-1; Tue, 08 Feb 2022 04:27:22 -0500 X-MC-Unique: WUakcmKTMwSExA6jFEhz4Q-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 90B101006AA3 for ; Tue, 8 Feb 2022 09:27:21 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6296178DA4 for ; Tue, 8 Feb 2022 09:27:21 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id E84E2A80D5C; Tue, 8 Feb 2022 10:27:19 +0100 (CET) Date: Tue, 8 Feb 2022 10:27:19 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] newlib: simplify nds32 automake checks Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220207061828.15199-1-vapier@gentoo.org> MIME-Version: 1.0 In-Reply-To: <20220207061828.15199-1-vapier@gentoo.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Feb 2022 09:27:25 -0000 On Feb 7 01:18, Mike Frysinger wrote: > This code is a bit more convoluted than it needs to be. GPR_SOURCES > is never set to anything, and the automake checks use negative logic > to add the SP & DP source files to dedicated variables that are only > expanded once. Get rid of the unused variable, use normal boolean > logic, and collapse the source settings into a single variable. > --- > newlib/libm/machine/nds32/Makefile.am | 17 +++++++---------- > newlib/libm/machine/nds32/Makefile.in | 18 ++++++++---------- > 2 files changed, 15 insertions(+), 20 deletions(-) LGTM Thanks, Corinna