public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH 4/6] newlib: drop libtool support
Date: Tue, 8 Feb 2022 10:47:39 +0100	[thread overview]
Message-ID: <YgI8Oz0Rfi/L5xRI@calimero.vinschen.de> (raw)
In-Reply-To: <20220208015706.6482-5-vapier@gentoo.org>

On Feb  7 20:57, Mike Frysinger wrote:
> This was only ever used for i?86-pc-linux-gnu targets, but that's been
> broken for years, and has since been dropped.  So clean this up too.
> 
> This also deletes the funky objectlist logic since it only existed for
> the libtool libraries.  Since it was the only thing left in the small
> Makefile.shared file, we can punt that too.
> ---
> [...]
> diff --git a/newlib/libm/configure.ac b/newlib/libm/configure.ac
> index a03ea3872bd5..7b4add03f3af 100644
> --- a/newlib/libm/configure.ac
> +++ b/newlib/libm/configure.ac
> @@ -20,15 +20,6 @@ AC_NO_EXECUTABLES
>  NEWLIB_CONFIGURE(..)
>  AC_PROG_CPP
>  
> -dnl We have to enable libtool after NEWLIB_CONFIGURE because if we try and
> -dnl add it into NEWLIB_CONFIGURE, executable tests are made before the first
> -dnl line of the macro which fail because appropriate LDFLAGS are not set.
> -_LT_DECL_SED
> -_LT_PROG_ECHO_BACKSLASH
> -if test "${use_libtool}" = "yes"; then
> -LT_INIT([win32-dll])
> -fi
> -
>  AC_TYPE_LONG_DOUBLE
>  AM_CONDITIONAL(HAVE_LONG_DOUBLE, test x"$ac_cv_type_long_double" = x"yes")
>  
> @@ -53,12 +44,8 @@ if test -n "${libm_machine_dir}"; then
>      *) AC_MSG_ERROR([unsupported libm_machine_dir "${libm_machine_dir}"]) ;;
>    esac
>  
> -  LIBM_MACHINE_DIR=machine/${libm_machine_dir}
> -  if test "${use_libtool}" = "yes"; then
> -    LIBM_MACHINE_LIB=${LIBM_MACHINE_DIR}/lib${libm_machine_dir}.${aext}
> -  else
> -    LIBM_MACHINE_LIB=${LIBM_MACHINE_DIR}/lib.${aext}
> -  fi
> +  LIBM_MACHINE_DIR=machine/${libm_machine_dir
                              ^^^^^^^^^^^^^^^^^^^
                              oops?


Corinna


  reply	other threads:[~2022-02-08  9:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-07  9:27 can i delete libtool / shared library support ? Mike Frysinger
2022-02-07 10:30 ` Mike Frysinger
2022-02-07 11:48 ` Corinna Vinschen
2022-02-07 19:30   ` Jeff Johnston
2022-02-08  1:57 ` [PATCH 0/6] delete i?86-pc-linux-gnu & libtool support Mike Frysinger
2022-02-08  1:57   ` [PATCH 1/6] newlib: drop i?86-pc-linux-* target support Mike Frysinger
2022-02-08  1:57   ` [PATCH 2/6] newlib: punt sys/linux support Mike Frysinger
2022-02-08  1:57   ` [PATCH 3/6] newlib: drop unused iconvdata Mike Frysinger
2022-02-08  4:55     ` Joel Sherrill
2022-02-08  1:57   ` [PATCH 4/6] newlib: drop libtool support Mike Frysinger
2022-02-08  9:47     ` Corinna Vinschen [this message]
2022-02-09  0:20       ` Mike Frysinger
2022-02-09 10:54         ` Corinna Vinschen
2022-02-09  8:41       ` Brian Inglis
2022-02-09 10:55         ` Corinna Vinschen
2022-02-08  1:57   ` [PATCH 5/6] newlib: drop support for $aext Mike Frysinger
2022-02-08  1:57   ` [PATCH 6/6] newlib: drop support for $oext Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YgI8Oz0Rfi/L5xRI@calimero.vinschen.de \
    --to=vinschen@redhat.com \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).