From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3124B3858D28 for ; Wed, 9 Feb 2022 11:02:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3124B3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644404554; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=VbpbR50FzDP04Z8ebUXXBaJcQxitmJe6Vg0wl+yLfhE=; b=f4I1HWJvpxRpfxS26m9BEWCm646JKg4V2rmNGzvofMGLBY22o8KDpv/4n9lT435a0E/SDH wlouKGyCH2uz9IsQIjZQnF+U+DSwYK9noSw02ge513QYUyPDUQZFsTLyhEA/0f9KLvHlFY ypJAlIlASoD9hscoeDIbPWsbSthPCpo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-237-Wf3-tcG_OXKbW1PY6nrHGA-1; Wed, 09 Feb 2022 06:02:33 -0500 X-MC-Unique: Wf3-tcG_OXKbW1PY6nrHGA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 440D11966320 for ; Wed, 9 Feb 2022 11:02:31 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1556F78DCF for ; Wed, 9 Feb 2022 11:02:31 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 92808A8089E; Wed, 9 Feb 2022 12:02:29 +0100 (CET) Date: Wed, 9 Feb 2022 12:02:29 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] libgloss: m68k: rename $DO to $TARGET Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220209051558.28100-1-vapier@gentoo.org> MIME-Version: 1.0 In-Reply-To: <20220209051558.28100-1-vapier@gentoo.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Feb 2022 11:02:36 -0000 On Feb 9 00:15, Mike Frysinger wrote: > The common $DO variable is used by the multilib logic to control which > target to multiplex. But the m68k subdir is also using $DO to control > which target (m68k or fido) to build. As we flatten things to automake, > this conflict shows up and breaks the m68k build. Just rename the m68k > variable to something unique to avoid it. > --- > libgloss/m68k/Makefile.in | 6 +++--- > libgloss/m68k/configure | 12 ++++++------ > libgloss/m68k/configure.ac | 10 +++++----- > 3 files changed, 14 insertions(+), 14 deletions(-) LGTM, please push. Corinna