From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 623703858C3A for ; Thu, 10 Feb 2022 15:04:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 623703858C3A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644505462; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=JfkC7eCHWACOY9Ug2eH0i1ots/ayijejdQ6Y+sACa9k=; b=AwohcvoMqiwvSx3mme7Cx2SdkGCeo7xAqaL86aUALyoy1uF2YmlY2t6VTyk6TECedz/A6I zTM22JlUN3c7IXWnjQwKnTEmDN9rMn8a9qjZcsAluhOB5sucUhwZePMQ9nlBDGC1hdrGvp ug4qANF1bOgg50eKwcF67SIcJdkNfMM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-335-JeC9OR3cNXGx3fjiXPk9GA-1; Thu, 10 Feb 2022 10:04:15 -0500 X-MC-Unique: JeC9OR3cNXGx3fjiXPk9GA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C4AB7100CCD2 for ; Thu, 10 Feb 2022 15:04:14 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 69CC1798AD for ; Thu, 10 Feb 2022 15:04:14 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 0A130A80733; Thu, 10 Feb 2022 16:04:13 +0100 (CET) Date: Thu, 10 Feb 2022 16:04:13 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] newlib: remove unused fenv flags Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220210055347.24825-1-vapier@gentoo.org> MIME-Version: 1.0 In-Reply-To: <20220210055347.24825-1-vapier@gentoo.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Feb 2022 15:04:24 -0000 On Feb 10 00:53, Mike Frysinger wrote: > These look like they were just copied & pasted from common/Makefile.am. > The funcs in this dir are all stubs that don't actually call any math > or builtin functions, and a simple compile shows they produce identical > object code. So delete to simplify the build rules. > --- > newlib/libm/fenv/Makefile.am | 3 -- > newlib/libm/fenv/Makefile.in | 90 +++--------------------------------- > 2 files changed, 6 insertions(+), 87 deletions(-) > > diff --git a/newlib/libm/fenv/Makefile.am b/newlib/libm/fenv/Makefile.am > index 50b59004c17e..66755e394cb7 100644 > --- a/newlib/libm/fenv/Makefile.am > +++ b/newlib/libm/fenv/Makefile.am > @@ -6,11 +6,8 @@ src = feclearexcept.c fe_dfl_env.c fegetenv.c fegetexceptflag.c \ > fegetround.c feholdexcept.c feraiseexcept.c fesetenv.c \ > fesetexceptflag.c fesetround.c fetestexcept.c feupdateenv.c > > -lib_a_CFLAGS = -fbuiltin -fno-math-errno > - > noinst_LIBRARIES = lib.a > lib_a_SOURCES = $(src) > -lib_a_CFLAGS += $(AM_CFLAGS) > > # A partial dependency list. > > -- > 2.34.1 Ok. Thanks, Corinna