From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 37DFE3858D1E for ; Thu, 10 Feb 2022 18:41:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 37DFE3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 10AD6342F84; Thu, 10 Feb 2022 18:41:54 +0000 (UTC) Date: Thu, 10 Feb 2022 13:41:57 -0500 From: Mike Frysinger To: C Howland Cc: newlib@sourceware.org Subject: Re: [PATCH] newlib: remove unused fenv flags Message-ID: Mail-Followup-To: C Howland , newlib@sourceware.org References: <20220210055347.24825-1-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Yb6FfrdHQ/b1V3yn" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Feb 2022 18:42:01 -0000 --Yb6FfrdHQ/b1V3yn Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 10 Feb 2022 13:02, C Howland wrote: > > On Feb 10 00:53, Mike Frysinger wrote: > > > These look like they were just copied & pasted from common/Makefile.a= m. > > > The funcs in this dir are all stubs that don't actually call any math > > > or builtin functions, and a simple compile shows they produce identic= al > > > object code. So delete to simplify the build rules. > > > --- > > > newlib/libm/fenv/Makefile.am | 3 -- > > > newlib/libm/fenv/Makefile.in | 90 +++-------------------------------= -- > > > 2 files changed, 6 insertions(+), 87 deletions(-) > > > > > > diff --git a/newlib/libm/fenv/Makefile.am b/newlib/libm/fenv/Makefile= =2Eam > > > index 50b59004c17e..66755e394cb7 100644 > > > --- a/newlib/libm/fenv/Makefile.am > > > +++ b/newlib/libm/fenv/Makefile.am > > > @@ -6,11 +6,8 @@ src =3D feclearexcept.c fe_dfl_env.c fegetenv= =2Ec > > fegetexceptflag.c \ > > > fegetround.c feholdexcept.c feraiseexcept.c fesetenv.c \ > > > fesetexceptflag.c fesetround.c fetestexcept.c feupdateenv.c > > > > > > -lib_a_CFLAGS =3D -fbuiltin -fno-math-errno > > > - > > > noinst_LIBRARIES =3D lib.a > > > lib_a_SOURCES =3D $(src) > > > -lib_a_CFLAGS +=3D $(AM_CFLAGS) > > > > > > # A partial dependency list. > > > > > > -- > > > 2.34.1 > > > > Ok. >=20 > No, not OK, it doesn't sound like. The fenv functions are all > machine-specific and the files in the libm/fenv directory are all stubs > (which they clearly state internally). Unless all targets were checked > (and it doesn't sound like they were), the conclusion is faulty that no > difference happens. Taking away -fbuiltin would definitely break any > machine source relying on it, but not the stubs. you seemed to be confused as to how this works. there is no machine code here. there are only stubs. machine code lives under libm/machine/$arch/, not under libm/fenv/. compiler flags in one directory only affects files in that one directory, they don't propagate out to every other directory in the build. i'll also note that none of the machine code explicitly uses -fno-builtin. there is a configure option for it that affects all newlib files instead. so either cite exactly what doesn't work, or withdraw your objection please. -mike --Yb6FfrdHQ/b1V3yn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmIFXHUACgkQQWM7n+g3 9YEtzg/+ONB002JyeOjRXE75QG7AlpGLNvh+/MmESlU3XVLfPNuRzZhgnhMzwKtA Euu/d5gsSiTDMTLMInPEs4oofgtAphKGRTcrI2SCnq7i/N9F76PoNY6Aq7jY5reZ HzQcLYPBIEEp1QC0odDq9YgFp2cQKfBSDGJu9cSD8rnDSxo7ZF3Lq94qvonarn7n Z/N6RUrXPEMLAgrmZHIiuW6V0FgBrMP54H00T3ztLAQ0Oyvjt7HJv4v7eRVzoinU 4zqw0H9iHNh1Lw/+idEqUGJ7+i3J5E2HyhemdLliiP+TgawGXdYU7+beEu04W7fg SrdBejQy3YJS90d5zTZbJ4NZFff3avELYTdMEdipZ20XiZ+pXh3oMctjif7GBbEQ 8Ih5xIHZYYvGeOYIrw+F09tP2w5bE4l8IXQUAkuCXnNNtl+UxoJgZS3ED3L9xrfX 7l5mewEHhFgsiKUZ+vA438mNo6O5bJLX4mHr29JidJaT14aADzGGL7oClQlQcJqB npNSnrqjrZ2v+3jfKrD3xEM5lOGeZY70stknBFP7dKBb4uFxQYREEsQqkrTPJ0Gx ibhLK0vv06/RR2QmrIMSgv3NjZjJLQoY1btisjnvEOvvQ+LUxG9dm8KF5gyiw1jW 39CQcQ/q0GzMLhOQZtbxgdfoOcPVlUGYS7z5DqBq7a9+PZ7wsSA= =6gYd -----END PGP SIGNATURE----- --Yb6FfrdHQ/b1V3yn--