From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 622193858D37 for ; Wed, 16 Feb 2022 08:43:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 622193858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645001022; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=tHoenJqIMAvwS3+WPjIpbGHbnzD5uQL1G4s6QMsx+ww=; b=WBnTjnqnP7acJ+8x+FyoTwFBiSxvXaRgxRmrpBFvwyRM9s6ThKB51vj6FbmW/8sgbKLOTh VZ187QWkQiF2B7FxKdW1GxUZwmt9k+smzlkjJ12Y+aWCCWAtLzgHjUZlG9quaYGy9cNn3A yFaQ5RycwmuLhLtytTMnGQxfWA2KR6A= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-127-phOb_qoSNwW61nMC4qwP7g-1; Wed, 16 Feb 2022 03:43:40 -0500 X-MC-Unique: phOb_qoSNwW61nMC4qwP7g-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C3305802926 for ; Wed, 16 Feb 2022 08:43:39 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 926D54F85D for ; Wed, 16 Feb 2022 08:43:39 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 1BA1BA807A1; Wed, 16 Feb 2022 09:43:38 +0100 (CET) Date: Wed, 16 Feb 2022 09:43:38 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH/RFC] libgloss: build with -nostdinc Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220212072337.21734-1-vapier@gentoo.org> MIME-Version: 1.0 In-Reply-To: <20220212072337.21734-1-vapier@gentoo.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Feb 2022 08:43:46 -0000 On Feb 12 02:23, Mike Frysinger wrote: > We don't want libgloss building against C library headers that happened > to be installed with the toolchain, so add -nostdinc to the build. We > still need access to the compiler internal headers, so probe those and > include them via -isystem. This uses a similar probing style as glibc, > which has used it for over a decade, so it should be safe & stable. > > This should prevent any latent bugs due to testing with a toolchain that > is fully configured & installed already. > --- > NB: tested against these targets: > aarch64-elf arc-elf arm-eabi > bfin-elf > cr16-elf cris-elf csky-elf > epiphany-elf > frv-elf > h8300-elf > i686-pc-cygwin iq2000-elf > m68k-elf microblaze-elf mips-elf mn10300-elf moxie-elf > nds32le-elf > or1k-elf > powerpc-elf > sparc-elf sparc-rtems > v850e-elf visium-elf > > libgloss/configure | 20 ++++++++++++++++++++ > libgloss/configure.ac | 11 +++++++++++ > 2 files changed, 31 insertions(+) Great, please push. Thanks, Corinna