From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A17AD3858D37 for ; Wed, 16 Feb 2022 08:52:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A17AD3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645001561; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=8x2j3YHcqIsfQJBn4Zl4p3s/8ia8lzsYD32WNrt6kZY=; b=Gq0OrQUH/9CYJwjWik/+wxGRn+bmXk0H56swNiU5URB2C7poeEoBLuBEh8dSa7mpISWRiX ULwOJ1lY/RG2gL6eJYNlYGBxM9l5LAO3lsHfZqFw9Kz9zhMSj2f9CE/nKLy9Iw8VBbtLe4 4ogijedgLlKE36PyKIxmfcUwrCKvFbE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-385-a1NaDPqENluB2p90OlYjdA-1; Wed, 16 Feb 2022 03:52:40 -0500 X-MC-Unique: a1NaDPqENluB2p90OlYjdA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 16BF410066FF for ; Wed, 16 Feb 2022 08:52:39 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DA7B37AB77 for ; Wed, 16 Feb 2022 08:52:38 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 6224CA807A1; Wed, 16 Feb 2022 09:52:37 +0100 (CET) Date: Wed, 16 Feb 2022 09:52:37 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] newlib: powerpc: simplify reallocr & callocr build logic Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220215030252.18371-1-vapier@gentoo.org> MIME-Version: 1.0 In-Reply-To: <20220215030252.18371-1-vapier@gentoo.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Feb 2022 08:52:42 -0000 On Feb 14 22:02, Mike Frysinger wrote: > Replace the custom build rules (which require copying & pasting from the > current Makefile) with small stub files. This allows us to drop the rules > entirely and let Automake provide everything. > --- > newlib/libc/machine/powerpc/Makefile.am | 8 +------- > newlib/libc/machine/powerpc/Makefile.in | 20 +++++++++++++------- > newlib/libc/machine/powerpc/vec_callocr.c | 2 ++ > newlib/libc/machine/powerpc/vec_reallocr.c | 2 ++ > 4 files changed, 18 insertions(+), 14 deletions(-) > create mode 100644 newlib/libc/machine/powerpc/vec_callocr.c > create mode 100644 newlib/libc/machine/powerpc/vec_reallocr.c LGTM Thanks, Corinna