From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 638A63858C78 for ; Tue, 1 Mar 2022 11:18:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 638A63858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646133534; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=KJ3S85/kC+IhWH/y2s2jXE/lduu9xds8+XrBjtP4KU4=; b=QetFnkfXYiQ7APhU+cxDM4HP/+WOQDBos6A8bFpiPqrb5boSGSvmuJVCYyEukTYcwFx9oO G/gcIMo6qVNuhfrZUsqp6tHtm2cjkME1DxDBvQbIvMDEBorah8p4tsgF0+4Zo/50gD+In8 RTjreU/8qVulQts+IEPWXGRfALeiU2Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-404-QpBcyGfWNtWH11xLd9Li8Q-1; Tue, 01 Mar 2022 06:18:53 -0500 X-MC-Unique: QpBcyGfWNtWH11xLd9Li8Q-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4529D801AB2 for ; Tue, 1 Mar 2022 11:18:52 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 168FC83195 for ; Tue, 1 Mar 2022 11:18:52 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id A3C15A80F58; Tue, 1 Mar 2022 12:18:50 +0100 (CET) Date: Tue, 1 Mar 2022 12:18:50 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] newlib: drop redundant AM_MAINTAINER_MODE call Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220301043238.2627-1-vapier@gentoo.org> MIME-Version: 1.0 In-Reply-To: <20220301043238.2627-1-vapier@gentoo.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2022 11:18:55 -0000 On Feb 28 23:32, Mike Frysinger wrote: > This is already called earlier in this file, so no need to do it again. > --- > newlib/acinclude.m4 | 2 -- > newlib/configure | 28 ---------------------------- > 2 files changed, 30 deletions(-) > > diff --git a/newlib/acinclude.m4 b/newlib/acinclude.m4 > index 60fe6ca74852..c50d233b1132 100644 > --- a/newlib/acinclude.m4 > +++ b/newlib/acinclude.m4 > @@ -132,8 +132,6 @@ dnl expanding them multiple times. > AC_REQUIRE([AC_PROG_INSTALL])dnl > AC_REQUIRE([AC_PROG_AWK])dnl > > -AM_MAINTAINER_MODE > - > . [$]{newlib_basedir}/configure.host > > NEWLIB_CFLAGS=${newlib_cflags} > -- > 2.34.1 Obvious, but the first invocation has unnecessary parens, which could go away, too. Thx, Corinna