From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 93C99385841E for ; Wed, 2 Mar 2022 01:30:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 93C99385841E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id B3E923430D3; Wed, 2 Mar 2022 01:30:13 +0000 (UTC) Date: Tue, 1 Mar 2022 20:30:17 -0500 From: Mike Frysinger To: newlib@sourceware.org Subject: Re: [PATCH] newlib: drop redundant AM_MAINTAINER_MODE call Message-ID: Mail-Followup-To: newlib@sourceware.org References: <20220301043238.2627-1-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="v2/4BvgOntQdeX2J" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2022 01:30:16 -0000 --v2/4BvgOntQdeX2J Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 01 Mar 2022 12:18, Corinna Vinschen wrote: > On Feb 28 23:32, Mike Frysinger wrote: > > This is already called earlier in this file, so no need to do it again. > > --- > > newlib/acinclude.m4 | 2 -- > > newlib/configure | 28 ---------------------------- > > 2 files changed, 30 deletions(-) > >=20 > > diff --git a/newlib/acinclude.m4 b/newlib/acinclude.m4 > > index 60fe6ca74852..c50d233b1132 100644 > > --- a/newlib/acinclude.m4 > > +++ b/newlib/acinclude.m4 > > @@ -132,8 +132,6 @@ dnl expanding them multiple times. > > AC_REQUIRE([AC_PROG_INSTALL])dnl > > AC_REQUIRE([AC_PROG_AWK])dnl > > =20 > > -AM_MAINTAINER_MODE > > - > > . [$]{newlib_basedir}/configure.host > > =20 > > NEWLIB_CFLAGS=3D${newlib_cflags} > > --=20 > > 2.34.1 >=20 > Obvious, but the first invocation has unnecessary parens, which > could go away, too. yeah, i was trying to keep it minimal, but i can fold that in too -mike --v2/4BvgOntQdeX2J Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmIeyKkACgkQQWM7n+g3 9YFF8w//e4yWdYYiMno5xJrJVgHLTa71+rKPdGWgVR6snpt+6nODFCtXkqrIYKUF TLWyXAAYH0QWvipHPN8twHrH21QTZabQEHpCKFGJtHdPI8/PrcQa3RTH0cb3swQ6 JbP3tzWiV0va87TRtM7AHzXS093NDVFjc1D4IHeWvtiIXlI0yrH7KVvq4MTbFCMh iZNq61zX0J0gZrdmlfnCgh5cAQwX1A+HU9dU7py/THsw8QV/QIk6mhuj+grnJTtn pDNyyYcoB4cdiIekFaXuDkhCCcq1BMxpOs4ghOkv2db7cKtusrmVq6v6jmcXVjj9 5i5Q9rdmligfDaZhRsgaksHlnUn+aq63kOvGsw/i6k09L7YkpKFGXBiqQ7FlG8Va ixQS5nDoR5rA/N8XZmGGJUdi/Y8RmD0H/vK/yF5e5UbsHTQdCkiPl/lC+CfgsHu7 +L0VOL92buO/D53TuL0bPlj8sswk2Q4xPNjJriSFB2rs95pFL6heOH6EgWLwD+00 rVGKpkvuqjBE4pAEALHQO24ZSvz1A3HOXP3HjSWH2sr/S+10pe4OUqNoIiUPBUfv yi9z80dnvJT7J2fc9Y49lyLldHWRmTjSNK3E4opDdan5GSV15MWZT8RgXvZu0+WE 7msJFg7fLltjtoBZ4WdWPlhwXW7dMJ9zQPy8ZNdBywoq6Xnakp0= =OVYz -----END PGP SIGNATURE----- --v2/4BvgOntQdeX2J--