From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 190BD3858D3C for ; Mon, 21 Feb 2022 12:33:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 190BD3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645446834; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=sRE00+I92pGfGL/JEovnNrtk6UACbLPbLOp/41W4+Jk=; b=jRdjaj8dq1qJsFJXyM/ZN07Ww8XXBThGM34ckPUYwd/gr+rPzBaQATDbW14ZrlbxAYL0/9 W4KwRRrxUgyw0MwZzcGHrWOrT7FrT43nVa3NmVt6sJ2UQXlGF81x04MI4E1CErcvM8FdBG uvJQrerITQrcyyNQvUFUGD2p5EkIIBs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-407-eDJZHs1cOKS4F4T22S7W4A-1; Mon, 21 Feb 2022 07:33:51 -0500 X-MC-Unique: eDJZHs1cOKS4F4T22S7W4A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ADF132F4A for ; Mon, 21 Feb 2022 12:33:50 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7E18B6FB12 for ; Mon, 21 Feb 2022 12:33:50 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id CB4B7A80D35; Mon, 21 Feb 2022 13:33:48 +0100 (CET) Date: Mon, 21 Feb 2022 13:33:48 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH v2 1/1] Make __sdidinit unused Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220218094525.8394-1-matthew.joyce@embedded-brains.de> <20220218094525.8394-2-matthew.joyce@embedded-brains.de> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Feb 2022 12:33:57 -0000 Hi Seb, On Feb 18 17:21, Sebastian Huber wrote: > Hello Corinna, > > On 18/02/2022 13:41, Corinna Vinschen wrote: > > Hi Matt, > > > > On Feb 18 10:45, Matthew Joyce wrote: > > > Remove dependency on __sdidinit member of struct _reent to check > > > object initialization. Like __sdidinit, the __cleanup member of > > > struct _reent is initialized in the __sinit() function. Checking > > > initialization against __cleanup serves the same purpose and will > > > reduce overhead in the __sfp() function in a follow up patch. > > > > The patch looks right now. But. > > > > What exactly are you going to do in __sfp? The reason I'm asking is > > that it's absolutely not clear yet which purpose this change serves. > > Looking at this patch, I only see that, rather than using an available > > flag, a pointer is now set to an invalid value -1, which looks more > > dangerous than what we did before. > > > > Care to explain or, even better, send the patch you have in mind? > > this is related to our attempt to use individual thread-local storage > objects instead of the monolithic struct _reent: > > https://sourceware.org/pipermail/newlib/2022/018855.html > > It turned out that this is not possible while _GLOBAL_REENT exists. Getting > rid of struct _reent members with similar functionality helps to refactor > the code. > > Instead of using -1 as a magic value a safer option would be to assign a > dummy function which does nothing: > [...] I like the idea. This looks good in the code. A comment in _cygtls::init_thread might be helpful in future, but it's not required for this patch submission. Matt, can you pleae resubmit with this change? Thanks, Corinna