From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id CA70B3858405 for ; Mon, 21 Feb 2022 20:30:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CA70B3858405 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 158E83430F9; Mon, 21 Feb 2022 20:30:11 +0000 (UTC) Date: Mon, 21 Feb 2022 15:30:11 -0500 From: Mike Frysinger To: newlib@sourceware.org Subject: Re: [PATCH v2] newlib: libm: merge build up a directory Message-ID: Mail-Followup-To: newlib@sourceware.org References: <20220212203450.19650-1-vapier@gentoo.org> <20220217044256.5483-1-vapier@gentoo.org> <5dc5d2ce-668b-49ac-bbf4-bbf0cdcb3da7@dronecode.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="/I0kQRs7NXGdoKTs" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Feb 2022 20:30:13 -0000 --/I0kQRs7NXGdoKTs Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 21 Feb 2022 20:24, Corinna Vinschen wrote: > On Feb 21 19:12, Jon Turney wrote: > > On 21/02/2022 18:30, Mike Frysinger wrote: > > > > > >=20 > > > > > > Can you please take a look? > > > > >=20 > > > > > how do you build cygwin ? i've just been doing w/newlib-cygwin g= it checkout: > > > > > $ ./configure --target=3Di686-pc-cygwin && make > > > > > $ ./configure --target=3Dx86_64-pc-cygwin && make > > > > > these are passing for me > > > >=20 > > > > You'll need to apply this patch: > > > >=20 > > > > https://cygwin.com/pipermail/cygwin-patches/2022q1/011766.html > > > >=20 > > > > Otherwise, you are linking with a stale libm.a left in your builddir > > > > from before these changes. > > >=20 > > > while i often test incremental changes, i `rm -rf` the build dir when= running > > > the full test suite to avoid possible issues like this. and in this = case, > > > both targets pass from a fresh build. > >=20 > > Have you run autogen.sh in the winsup/ directory? The top-level will j= ust > > ignore it if there is no ./configure there, and it's not checked in. >=20 > Also, always build in an external build dir. This may not be a problem > anymore, but in the olden days a build in the sourcedir was broken. i always build in sep dir since i'm building ~30 targets in parallel looks like i needed -U_FORTIFY_SOURCE and --with-cross-bootstrap too. my patch for libm.a fixes linking of the dll files afaict. there's some build errors in the docs that i don't understand, but they don't seem relevant. -mike --/I0kQRs7NXGdoKTs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmIT9lMACgkQQWM7n+g3 9YGTuxAAla3IcAEnQ9pNnLL/q9PEyl7DFau4j4Al+yzYXUzzBoqvyul5XvA4AW8M 4JK5BU+T/lUBJzpxYfWLBrYcHrAQXYf3gCo5G/pAQoAgfRGTfRW6vNkTCUgxkwnx DyG/51Wcy/DS+CtRBULK7CvDVt770waMjgIKDIc0M1BzE4uU9fA2yCdGjyuQ3idD +LB5uInyDnC3LDhSJvfi4rwhr7xw2Wr9/w7W7272ToMeIhZcOc4+ee+mxfa6YP3m 1zoN8FYU9sHjxKiw251bd3C8GCSw/QOythWsgQVeRAUnfjbwOgMdsLx+tj9h3rP0 k+ty7j87ucW1HHi2rHv5qzVbil0eg6qjp8gHFqsMLay9z/4NEkVgwVr/aFwKTPah 1CSvwp471pWAT+IgqAYV6AUTyTHdN1WVQT1g0riBWfNsWVBO0zF28v9X2xiji2RX MSeyTyN4O4gP2T7OA/MSd0aoqvhGYSF8Mz94k63wkuklMF9KPULQ4aHKzh495kif Ri7j+w9RrQ8KZSR+nSXshEy0zlsFKqQAJs2zSPShuNmg+FyTesspkA/A0ZYkaE8N aET9XjOkcL9RHW6iLLc4PeNxn1RgqwpyRq+cp044tRnOVwwhmny/chn23Y7X6Ji/ Ocb81HzDloeQ6GsY4rGrSvBENs8PICZPYUz0kn3SLk/2gcPS3NA= =2tGG -----END PGP SIGNATURE----- --/I0kQRs7NXGdoKTs--