From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 707C53858408 for ; Mon, 21 Feb 2022 19:24:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 707C53858408 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645471484; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=zJnGVl8ZdUDIu50M0cZk3zh/c/IqjHkiceyO+HpIskI=; b=Vla50hwGfbuMuu1e5iuexaudSGoIV6P3NS6hWtWWt6JEGLgy3sdoByJJPggqWJaoFDULE5 H8h6x+fWFEbQ2ICqgSBbIATbCj+PZbsmDyo+MuRdxP24HsEcGlebXRVAVU0NX4QOgo1Tgu +HlOEQQKvPYgl8ypDC3nrnG968y215Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-618-GVRvx5KKO92ZM70-WmN-Sg-1; Mon, 21 Feb 2022 14:24:35 -0500 X-MC-Unique: GVRvx5KKO92ZM70-WmN-Sg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6853A1898290 for ; Mon, 21 Feb 2022 19:24:34 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 385981000180 for ; Mon, 21 Feb 2022 19:24:34 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id A8BFEA80F53; Mon, 21 Feb 2022 20:24:32 +0100 (CET) Date: Mon, 21 Feb 2022 20:24:32 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH v2] newlib: libm: merge build up a directory Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220212203450.19650-1-vapier@gentoo.org> <20220217044256.5483-1-vapier@gentoo.org> <5dc5d2ce-668b-49ac-bbf4-bbf0cdcb3da7@dronecode.org.uk> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Feb 2022 19:24:46 -0000 On Feb 21 19:12, Jon Turney wrote: > On 21/02/2022 18:30, Mike Frysinger wrote: > > > > > > > > > > Can you please take a look? > > > > > > > > how do you build cygwin ? i've just been doing w/newlib-cygwin git checkout: > > > > $ ./configure --target=i686-pc-cygwin && make > > > > $ ./configure --target=x86_64-pc-cygwin && make > > > > these are passing for me > > > > > > You'll need to apply this patch: > > > > > > https://cygwin.com/pipermail/cygwin-patches/2022q1/011766.html > > > > > > Otherwise, you are linking with a stale libm.a left in your builddir > > > from before these changes. > > > > while i often test incremental changes, i `rm -rf` the build dir when running > > the full test suite to avoid possible issues like this. and in this case, > > both targets pass from a fresh build. > > Have you run autogen.sh in the winsup/ directory? The top-level will just > ignore it if there is no ./configure there, and it's not checked in. Also, always build in an external build dir. This may not be a problem anymore, but in the olden days a build in the sourcedir was broken. Corinna