From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 7F0553858406 for ; Mon, 28 Feb 2022 12:07:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7F0553858406 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646050079; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=30xn360Zno0yxCP4wdO+Pwu8UxkOW5XYMD4IWnvS7w4=; b=FvJexw5g8UQ+Mg9hKYOq/WSCyp/rgzpCssT88PdzNVUTkTD7D5/qCGa5BYhjVhwHmTYO+3 bAsevZ/pe23GmF8CLe7ZUcki5IfBvFPPYxejZJjKrs3Ui8A5CARSbzPadoxH8DqZ4D9TKF 2+mliNCqGJCAon0GV4o0KAXjk/CLIao= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-15-dsLE3FAHNuOmsqWu-DXSig-1; Mon, 28 Feb 2022 07:07:57 -0500 X-MC-Unique: dsLE3FAHNuOmsqWu-DXSig-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DB54251E0 for ; Mon, 28 Feb 2022 12:07:56 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 974351053B16 for ; Mon, 28 Feb 2022 12:07:56 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 2692AA80CE4; Mon, 28 Feb 2022 13:07:55 +0100 (CET) Date: Mon, 28 Feb 2022 13:07:55 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] newlib: libc: move stdio multiplex logic from build to source files Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220226044748.32601-1-vapier@gentoo.org> MIME-Version: 1.0 In-Reply-To: <20220226044748.32601-1-vapier@gentoo.org> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Feb 2022 12:08:00 -0000 On Feb 25 23:47, Mike Frysinger wrote: > Rather than define per-object rules in the Makefile, have small files > that define & include the right content. This simplifies the build > rules, and makes understanding the source a little easier (imo) as it > makes all the subdirs behave the same: you have 1 source file and it > produces 1 object. It's also about the same amount of boiler plate, > without having to define custom build rules that can fall out of sync. > Some of these rules were already unnecessary as they were compiling a > single source file into the same named object w/out custom flags, and > Automake handles that for us completely. > > This will also be important as we merge the libc.a build into the top > dir since it relies on a single flat list of objects for overrides. > > Also take the opportunity to clean up the unnecessary header deps in > here. Automake provides dependency generation for free now. That sounds like a really good idea. Thx, Corinna