From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 18C923858C20 for ; Mon, 28 Feb 2022 10:40:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 18C923858C20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646044848; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=Ww8hNwHviNfkPBz1SDhsWR6p+oCAAmzn3LDR6mBV8F8=; b=U+qrdWh1BAnuOwSqsqf2RgvHIdA/c5PvHShDR3XStdvCgO+aUC9QEA5/eaWma6HUK2wBzY f4OUQ0TclgnbeRJLFSlPf/iQzyAEig0vgcIYO+n8082HRlhTFj5RXKyz9CyihtgV06loXP Qjviefm09jgZCxs6hSV8m8mAtN/RBGA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-657-0FDXIXZKPjWk4mO6z3h8BQ-1; Mon, 28 Feb 2022 05:40:47 -0500 X-MC-Unique: 0FDXIXZKPjWk4mO6z3h8BQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5D28680733B for ; Mon, 28 Feb 2022 10:40:46 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2E8BF1078672 for ; Mon, 28 Feb 2022 10:40:46 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id B398CA80CE4; Mon, 28 Feb 2022 11:40:44 +0100 (CET) Date: Mon, 28 Feb 2022 11:40:44 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] newlib: speed up targ-include setup & add error checking Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220225002737.21507-1-vapier@gentoo.org> <20220226041050.23067-1-vapier@gentoo.org> MIME-Version: 1.0 In-Reply-To: <20220226041050.23067-1-vapier@gentoo.org> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Feb 2022 10:40:50 -0000 On Feb 25 23:10, Mike Frysinger wrote: > The current targ-include setup runs `cp` and `basename` for every > header file it installs, in serial. This can be a little noticeable > on systems, so cleanup the logic to rely on cp's ability to copy > multiple files to a single directory. > > We still need the for loop to check for empty directories with no > headers (i.e. the glob doesn't match anything). > --- > newlib/Makefile.am | 84 +++++++++++------------------------------ > newlib/Makefile.in | 93 +++++++++++++--------------------------------- > 2 files changed, 47 insertions(+), 130 deletions(-) LGTM. Please squash these two. Thx, Corinna