From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id D09723858019 for ; Mon, 14 Mar 2022 17:06:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D09723858019 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 272BB3430A1; Mon, 14 Mar 2022 16:58:09 +0000 (UTC) Date: Mon, 14 Mar 2022 12:58:16 -0400 From: Mike Frysinger To: Sebastian Huber Cc: newlib@sourceware.org Subject: Re: [PATCH] newlib: fix build with Mail-Followup-To: Sebastian Huber , newlib@sourceware.org References: <20220314032559.24535-1-vapier@gentoo.org> <48013422-0fd4-887f-bb5c-9d620abfe0e3@embedded-brains.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZfNaZT3WIgiqJhf1" Content-Disposition: inline In-Reply-To: <48013422-0fd4-887f-bb5c-9d620abfe0e3@embedded-brains.de> X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Mar 2022 17:06:07 -0000 --ZfNaZT3WIgiqJhf1 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 14 Mar 2022 08:36, Sebastian Huber wrote: > On 14/03/2022 04:25, Mike Frysinger wrote: > > __builtin_mul_overflow showed up with gcc-5, so stub it out for older > > versions. >=20 > The __builtin_mul_overflow() performs a multiplication and an overflow=20 > check. Just replacing this with 0 is not the same. i'm aware it does the check. i figured since