From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 6CB7B3858C83 for ; Wed, 9 Mar 2022 08:07:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6CB7B3858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646813275; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=hmAvHGIMdIk9w2At5w/q8nC2SktaD/GySt26/nRjpkQ=; b=UOqfH3nVY0WMGG76DUO8KOhCVHjVegtRNUIlEJcupt42TyYox8fepnHf9eTcAED4F8BuVd C02Z/C4a0OJMNeQWlLRNIOXi5GoDUQAlR5CO5wNDbYhKp2KOXHvEfcXObzxcoZFVuU4MHJ dd13Kag0sg1l8vw1my7W4rtNZuxTgSk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-207-2-FR3xzLNNi5DnjKXD0pEg-1; Wed, 09 Mar 2022 03:07:53 -0500 X-MC-Unique: 2-FR3xzLNNi5DnjKXD0pEg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6EA451006AA7 for ; Wed, 9 Mar 2022 08:07:52 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 416FE827AE for ; Wed, 9 Mar 2022 08:07:52 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id CB15AA80894; Wed, 9 Mar 2022 09:07:50 +0100 (CET) Date: Wed, 9 Mar 2022 09:07:50 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] newlib: libc: merge build up a directory Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220302013959.511-1-vapier@gentoo.org> MIME-Version: 1.0 In-Reply-To: <20220302013959.511-1-vapier@gentoo.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2022 08:07:58 -0000 Hi Mike, On Mar 1 20:39, Mike Frysinger wrote: > Convert all the libc/ subdir makes into the top-level Makefile. This > allows us to build all of libc from the top Makefile without using any > recursive make calls. This is faster and avoids the funky lib.a logic > where we unpack subdir archives to repack into a single libc.a. The > machine override logic is maintained though by way of Makefile include > ordering, and source file accumulation in libc_a_SOURCES. > > There's a few dummy.c files that are no longer necessary since we aren't > doing the lib.a accumulating, so punt them. The patch doesn't apply cleanly on current master. Can you please have a look? $ git am x.patch Applying: newlib: libc: merge build up a directory error: patch failed: newlib/libc/machine/xstormy16/Makefile.am:1 error: newlib/libc/machine/xstormy16/Makefile.am: patch does not apply error: patch failed: newlib/libc/stdlib/Makefile.am:1 error: newlib/libc/stdlib/Makefile.am: patch does not apply Patch failed at 0001 newlib: libc: merge build up a directory [...] Thanks, Corinna