From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 724A83858C20 for ; Wed, 9 Mar 2022 08:26:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 724A83858C20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646814394; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=QpnpO39qPsiPeOSUVgOKlVbpDIETMZbV8s1Ab9zXGnI=; b=WQkBM7cEpl5QUdGeuWT9JbKN38LWVKHNOAD2dIE8wZeGq/mgb8OTUkOY86NqO4611RJUz+ xLzm7el3phJ6Js2pPtgWpLZTDjb740rDVL1wE/GW8ZjpvkJ3KaADOUNzbxdL0GFhh2Qrio 1Yl/vF3eoWwObVhPGscvO8Vg4UOxqQY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-85-8pWnie_YMM-b59xlgSllJA-1; Wed, 09 Mar 2022 03:26:30 -0500 X-MC-Unique: 8pWnie_YMM-b59xlgSllJA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E16E9FC80 for ; Wed, 9 Mar 2022 08:26:29 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B15AE5ED37 for ; Wed, 9 Mar 2022 08:26:29 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 525A0A80894; Wed, 9 Mar 2022 09:26:28 +0100 (CET) Date: Wed, 9 Mar 2022 09:26:28 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] build: Avoid length() GNU awk extension Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220309073105.129187-1-sebastian.huber@embedded-brains.de> MIME-Version: 1.0 In-Reply-To: <20220309073105.129187-1-sebastian.huber@embedded-brains.de> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2022 08:26:35 -0000 On Mar 9 08:31, Sebastian Huber wrote: > Other awk implementations such as mawk do not support the length() function. > --- > newlib/Makefile.am | 4 ++-- > newlib/Makefile.in | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/newlib/Makefile.am b/newlib/Makefile.am > index ba0a3822f..81719660c 100644 > --- a/newlib/Makefile.am > +++ b/newlib/Makefile.am > @@ -93,8 +93,8 @@ CLEANFILES += libg.a > ## https://sourceware.org/PR28917 > AWK_UNIQUE_OBJS = $(AWK) '{ \ > for (i = NF; i > 0; --i) { \ > - split($$i, parts, "/"); \ > - name = parts[length(parts)]; \ > + count = split($$i, parts, "/"); \ > + name = parts[count]; \ > if (!(name in seen)) { \ > objs[i] = $$i; \ > seen[name] = 1; \ > diff --git a/newlib/Makefile.in b/newlib/Makefile.in > index e0deacb61..7de777879 100644 > --- a/newlib/Makefile.in > +++ b/newlib/Makefile.in > @@ -1380,8 +1380,8 @@ toollib_LIBRARIES = libm.a \ > toollib_DATA = $(CRT0) $(CRT1) > AWK_UNIQUE_OBJS = $(AWK) '{ \ > for (i = NF; i > 0; --i) { \ > - split($$i, parts, "/"); \ > - name = parts[length(parts)]; \ > + count = split($$i, parts, "/"); \ > + name = parts[count]; \ > if (!(name in seen)) { \ > objs[i] = $$i; \ > seen[name] = 1; \ > -- > 2.34.1 LGTM Thanks, Corinna