From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 818283858D28 for ; Tue, 15 Mar 2022 03:15:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 818283858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 2ED5B342B76; Tue, 15 Mar 2022 03:15:09 +0000 (UTC) Date: Mon, 14 Mar 2022 23:15:18 -0400 From: Mike Frysinger To: newlib@sourceware.org Subject: Re: [PATCH v2] newlib: libc: merge build up a directory Message-ID: Mail-Followup-To: newlib@sourceware.org References: <20220302013959.511-1-vapier@gentoo.org> <20220315030437.17762-1-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rfcAM6wjnTcEFNqm" Content-Disposition: inline In-Reply-To: <20220315030437.17762-1-vapier@gentoo.org> X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Mar 2022 03:15:21 -0000 --rfcAM6wjnTcEFNqm Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 14 Mar 2022 23:04, Mike Frysinger wrote: > Convert all the libc/ subdir makes into the top-level Makefile. This > allows us to build all of libc from the top Makefile without using any > recursive make calls. This is faster and avoids the funky lib.a logic > where we unpack subdir archives to repack into a single libc.a. The > machine override logic is maintained though by way of Makefile include > ordering, and source file accumulation in libc_a_SOURCES. >=20 > There's a few dummy.c files that are no longer necessary since we aren't > doing the lib.a accumulating, so punt them. > --- > v2 > - fix some bad paths & compiler settings & missing \ in stdio subdirs i also pushed this to topic/vapier-libc if you want to fetch that to test. i checked against these targets: aarch64-elf arc-elf arm-eabi bfin-elf cr16-elf cris-elf csky-elf epiphany-elf frv-elf h8300-elf i386-elf i686-pc-cygwin iq2000-elf lm32-elf m68k-elf microblaze-elf mips-elf mn10300-elf moxie-elf nds32le-elf or1k-elf powerpc-elf sparc-elf sparc-rtems v850e-elf visium-elf x86_64-pc-cygwin xstormy16-elf i checked the newlib object lists to make sure they matched and the disassembly was the same between them. there were some changes, but they were expected: no longer including dummy.o, and for some ports, using libc_a- prefix on the objects. cygwin newlib works, but winsup breaks because it has a direct reference on an internal lib.a file that no longer exists: libssp.a: $(LIB_NAME) $(newlib_build)/libc/ssp/lib.a $(AM_V_GEN)$(speclib) $^ $(@F) i could fix it like so: --- a/winsup/cygwin/Makefile.am +++ b/winsup/cygwin/Makefile.am @@ -719,7 +719,7 @@ libacl.a: $(LIB_NAME) sec_posixacl.o $(AM_V_GEN)$(speclib) $^ $(@F) =20 -libssp.a: $(LIB_NAME) $(newlib_build)/libc/ssp/lib.a +libssp.a: $(LIB_NAME) $(wildcard $(newlib_build)/libc/ssp/*.o) $(AM_V_GEN)$(speclib) $^ $(@F) =20 # not sure what the preference is here. -mike --rfcAM6wjnTcEFNqm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmIwBMYACgkQQWM7n+g3 9YHzdw/+NciftvuAXAJbPl4yztLh0pp7vo7bCsWdWIRBdfCGK57iJ1LSvPgTCQCT e9HvwgU6q10zhSaWRqhiLBzJrhk//W0i0qg6I514XDkWPD0Mkb4763EIqm23PGgS TOW53FxEULpTNzvOt6L5AN9QZvBQF2CFDhZSYhJXukqxohz3e13y6B06IUjUKXJK +QNf4qjx2tiOUW+MY3aLZg246sdU3lJaZrLyjqGDzDWWTOiX1YAdIRH89hVgWyu1 73alC3nJtBardCriytrUVCo+0ITDXlvm4RLxYHnB8edrrnXqMRY88OT8kSgF8MhU cj0RSZn1PcCEyIMusfBMql0H7J1AnCy1elOUSyx1kWScK3+0BPeNjgNfDeDDcCOC vLm2SLLxywtAJesPIhx3i19U6T8bHEp18b3SMb+P6Z04bF7Y2yfZGGlakOw/v6Ae 3NNkAAdEA2M1y4UxcuhaC2uR7IjzPOIZlGP99Lp+0Gpjq1AkFUKdnXa0cvcjlka+ 4yU1KqRCo7p2fET9uF0EeJtDSGhllUfLp28+B9xjedg2bLUAxh+cMPIPPkbZ7g94 FZPyAxfVl+3GAz+yBR1/nlc4RjLj8hMYlFqCsX9lgCDGTlXl6/VpQvQEdUH/h83h qsDOWhe+ScAGPshwu7QBUD5ZMfudS3ylxVSjQRDgaR8F/nJHI98= =eBVr -----END PGP SIGNATURE----- --rfcAM6wjnTcEFNqm--