From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 70FF63858D20 for ; Tue, 15 Mar 2022 23:50:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 70FF63858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id B0E09343624; Tue, 15 Mar 2022 23:50:00 +0000 (UTC) Date: Tue, 15 Mar 2022 19:50:08 -0400 From: Mike Frysinger To: Joel Sherrill Cc: Sebastian Huber , Newlib Subject: Re: [PATCH newlib] libc/include/malloc.h: Add prototype for GNU extension malloc_usable_size() Message-ID: Mail-Followup-To: Joel Sherrill , Sebastian Huber , Newlib References: <20220315151644.369-1-joel@rtems.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HGbDFn3g9PpreUV/" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Mar 2022 23:50:03 -0000 --HGbDFn3g9PpreUV/ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On 15 Mar 2022 15:54, Joel Sherrill wrote: > The prototype isn't wrapped by __GNU_VISIBLE. Should it be? we're talking about malloc.h here. this is already a non-standard header. the standard malloc APIs are defined in stdlib.h: https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/stdlib.h.html so i'm not sure how much value there is annotating standards in a header that is not in any standard, and whose inclusion clearly declares "i am not conforming to any standards". we could put a disclaimer/explanation at the top of the header file to make this a bit more clear. -mike --HGbDFn3g9PpreUV/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmIxJjAACgkQQWM7n+g3 9YHIdQ//RZa3dtIM4cwdz4i8soff+za/Polm33FVKVHa/ZzCdS73Tf95oiGGZDV4 17GVaYxg91jjKezNPMcPL4BWpnQoOvBkgy6GyW4JTxBk26H5PewVyscLtCdDaVb9 qo6dsVmWMZeARbTC09/+Mf7zOXwO5OqHFq8vXEjqL6rfC40DKqB1dCYR31It0B2Q SZV58DF1ieU9pz/hqabxSSygxBEdggC/M9RvAhKwRbWOgQLz9LOOf9S7BXLU1HbY NXuP49k6wsNXKXMmhUD+prf7VYYOTAjIK0ETxpawutLkEap4KVB/J5i7sPiYixBB E96VR5DjiB2cGODS2uw3ccSUo5iBM9dIvWaom7kJlVDY4mNR4TzgD0/f1ffncDuE n8EZVumMJ9gASN9tdNCq0N1Bn/y5N6BYXdgCw2qNRgYY5Mz5RTlrcD9PGJLtUMxx 3xNFXNtahzIvtGqhP0sfKVbMup9349gb+T/b15MuQxBLefMFGRV9c7SAwpBVI3SP Wt7/x+nxDMeDGAv3cOBpzyyG1gulaDTfyQcpgjkPot0GHHWSfZ724eREK8NWrZ4H j+gC1+qsPinTHuRDvwOgEO1E7vG+rGDUOOzSYSzMXWVCzV87KWYPEEMEjg7jmh9d BrrdPjKGWr0LrFODyJmCRj9kVhAFHrbBQoCnqPLYev7eDKaxe4Q= =5bco -----END PGP SIGNATURE----- --HGbDFn3g9PpreUV/--