From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id D4879385843F for ; Tue, 15 Mar 2022 23:53:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D4879385843F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 4012234363F; Tue, 15 Mar 2022 23:53:51 +0000 (UTC) Date: Tue, 15 Mar 2022 19:54:00 -0400 From: Mike Frysinger To: Richard Earnshaw Cc: newlib@sourceware.org Subject: Re: [PATCH v2] newlib: fix build with Mail-Followup-To: Richard Earnshaw , newlib@sourceware.org References: <20220314032559.24535-1-vapier@gentoo.org> <20220315032550.16502-1-vapier@gentoo.org> <2c68b0f8-03ad-d93d-dd35-002a66576ff8@foss.arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0E9mPFBQl4/ElFXZ" Content-Disposition: inline In-Reply-To: <2c68b0f8-03ad-d93d-dd35-002a66576ff8@foss.arm.com> X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Mar 2022 23:53:54 -0000 --0E9mPFBQl4/ElFXZ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 15 Mar 2022 12:41, Richard Earnshaw wrote: > On 15/03/2022 03:25, Mike Frysinger wrote: > > __builtin_mul_overflow showed up with gcc-5, so stub it out for older > > versions. > > --- > > newlib/libc/include/sys/cdefs.h | 4 ++++ > > 1 file changed, 4 insertions(+) > >=20 > > diff --git a/newlib/libc/include/sys/cdefs.h b/newlib/libc/include/sys/= cdefs.h > > index da729092185c..e51f7f4b873a 100644 > > --- a/newlib/libc/include/sys/cdefs.h > > +++ b/newlib/libc/include/sys/cdefs.h > > @@ -416,6 +416,10 @@ > > #define __unreachable() ((void)0) > > #endif > > =20 > > +#if !__GNUC_PREREQ__(5, 0) > > +#define __builtin_mul_overflow(a, b, size) ({ *(size) =3D (a) * (b); 0= ; }) >=20 > Wouldn't > (*(size) =3D (a) * (b), 0) >=20 > be more portable (avoiding the GNU statement expression extension)? sure, that works too, thanks -mike --0E9mPFBQl4/ElFXZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmIxJxgACgkQQWM7n+g3 9YED+w//bXrsR6iniSmK6Q5tGrLmcB2hUV6bvC+rmYv0CHotbBEhWLmyPPxWC0Ga qN8PuQoVIzrWDI/j/R5QyJs23uSL4Gb3QfgHyWl0AP/gl6i7MUUjneK2qoJX3yqC SBdAAYMj8/dAOWdbys1C6bNV+JiFk+hAueUlrZRlOnXUDvbD7Ymo/HBANaiw0eem kmyO7vpp+oNFMQ5hE2qaT3lWOwE4vuP/peGoI19xRP3RGi27GA490tEU/PNXWRvH WDkNTk+GwgVh/nfGUNwIkbTd7gpNesFc4cEWo5/knyctNbZFxyE0TEkhhMl0rDXT jI1XZdyMz9rT+m155ET4omUD2Cds2PPUqcsWZUpnuG4KkrH+wFShLzIXcEDLFGZM FXBFj5UAec9Zns9zuMTf/NlfRKN2ovscpb3lEBGYiEPjVU65af1hjqbww5d7mSuy ePSSljROWss+gVAC8o+0MhIH+4pUCWCszKlSJao5Gcf5vWh4bgN5edcOMX3ViscH 4IrHiVWYnD2YI0HxH39pqmhBmt7x270H5u1NmsnQsJn4liFh5OfASylA/qQgymL7 A1yhkGdrlgQ0LPoyf3Uy/R+7E6xd+O9zf8HvRzR1pyHGlGTO+JjJID/2Zni8TNDj pg9nuol8N+ioYie2LvGOz5BA+1xVakrSgrTN5WY8D2WqB7ewSGk= =QFjS -----END PGP SIGNATURE----- --0E9mPFBQl4/ElFXZ--