From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E79B9385E83E for ; Wed, 16 Mar 2022 07:25:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E79B9385E83E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647415501; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=h5F0mKW12Or7Ik7djI/w+QwXdo9LH413LCTxDAQdcgk=; b=dd8HeKw3P+5e3Nze4gwQyhySxIpTmL/LWaqNj9IyofkOCh/P3JNJU2RqTmRSoJgFx6VEIb hc2dCi+AkmoatRA4sxT7Ono7oUcgqa1O5PH1ZAcHSY/p3/zP95Wtn4Dv+jRM3WWG0nMtz0 XtirxxMl9k/OXKKazRAXYXM64xUJQOY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-652-w20V1RLfNtWTQxiwcXdZmg-1; Wed, 16 Mar 2022 03:25:00 -0400 X-MC-Unique: w20V1RLfNtWTQxiwcXdZmg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E1AC6811E75 for ; Wed, 16 Mar 2022 07:24:59 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BEA8A40CFD10 for ; Wed, 16 Mar 2022 07:24:59 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 91207A8071E; Wed, 16 Mar 2022 08:24:58 +0100 (CET) Date: Wed, 16 Mar 2022 08:24:58 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH v2] newlib: libc: merge build up a directory Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220302013959.511-1-vapier@gentoo.org> <20220315030437.17762-1-vapier@gentoo.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Mar 2022 07:25:03 -0000 On Mar 14 23:15, Mike Frysinger wrote: > On 14 Mar 2022 23:04, Mike Frysinger wrote: > > Convert all the libc/ subdir makes into the top-level Makefile. This > > allows us to build all of libc from the top Makefile without using any > > recursive make calls. This is faster and avoids the funky lib.a logic > > where we unpack subdir archives to repack into a single libc.a. The > > machine override logic is maintained though by way of Makefile include > > ordering, and source file accumulation in libc_a_SOURCES. > > > > There's a few dummy.c files that are no longer necessary since we aren't > > doing the lib.a accumulating, so punt them. > > --- > > v2 > > - fix some bad paths & compiler settings & missing \ in stdio subdirs > > i also pushed this to topic/vapier-libc if you want to fetch that to test. > > i checked against these targets: > aarch64-elf arc-elf arm-eabi > bfin-elf > cr16-elf cris-elf csky-elf > epiphany-elf > frv-elf > h8300-elf > i386-elf i686-pc-cygwin iq2000-elf > lm32-elf > m68k-elf microblaze-elf mips-elf mn10300-elf moxie-elf > nds32le-elf > or1k-elf > powerpc-elf > sparc-elf sparc-rtems > v850e-elf visium-elf > x86_64-pc-cygwin xstormy16-elf > > i checked the newlib object lists to make sure they matched and the > disassembly was the same between them. there were some changes, but > they were expected: no longer including dummy.o, and for some ports, > using libc_a- prefix on the objects. > > cygwin newlib works, but winsup breaks because it has a direct > reference on an internal lib.a file that no longer exists: > libssp.a: $(LIB_NAME) $(newlib_build)/libc/ssp/lib.a > $(AM_V_GEN)$(speclib) $^ $(@F) > > i could fix it like so: > > --- a/winsup/cygwin/Makefile.am > +++ b/winsup/cygwin/Makefile.am > @@ -719,7 +719,7 @@ > libacl.a: $(LIB_NAME) sec_posixacl.o > $(AM_V_GEN)$(speclib) $^ $(@F) > > -libssp.a: $(LIB_NAME) $(newlib_build)/libc/ssp/lib.a > +libssp.a: $(LIB_NAME) $(wildcard $(newlib_build)/libc/ssp/*.o) > $(AM_V_GEN)$(speclib) $^ $(@F) > > # > > not sure what the preference is here. > -mike LGTM. Just merge the above patch into yours and push it as one. Thanks, Corinna