From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vapier@gentoo.org>
Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183])
 by sourceware.org (Postfix) with ESMTP id 79B3B385ED69
 for <newlib@sourceware.org>; Sun, 20 Mar 2022 01:20:07 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 79B3B385ED69
Authentication-Results: sourceware.org;
 dmarc=pass (p=none dis=none) header.from=gentoo.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org
Received: by smtp.gentoo.org (Postfix, from userid 559)
 id 16D8A340FDC; Sun, 20 Mar 2022 01:20:04 +0000 (UTC)
Date: Sat, 19 Mar 2022 21:20:14 -0400
From: Mike Frysinger <vapier@gentoo.org>
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: Newlib <newlib@sourceware.org>
Subject: Re: Avoid using common symbols in v850 libgloss
Message-ID: <YjaBTtkfURhTh5Ts@vapier>
Mail-Followup-To: Jeff Law <jeffreyalaw@gmail.com>,
 Newlib <newlib@sourceware.org>
References: <c0cd56a5-db36-1bac-01d4-8b06d91a604e@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="UDkAR/81OFRWN/yl"
Content-Disposition: inline
In-Reply-To: <c0cd56a5-db36-1bac-01d4-8b06d91a604e@gmail.com>
X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: newlib@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Newlib mailing list <newlib.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/newlib>,
 <mailto:newlib-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/newlib/>
List-Post: <mailto:newlib@sourceware.org>
List-Help: <mailto:newlib-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/newlib>,
 <mailto:newlib-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sun, 20 Mar 2022 01:20:09 -0000


--UDkAR/81OFRWN/yl
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 09 Feb 2022 18:58, Jeff Law wrote:
> I've had this lying around for probably a year or two at this point.=C2=
=A0=C2=A0=20
> It just changes all the instance of "errno" from a common symbol to an=20
> extern.=C2=A0 I can't offhand recall where the actual definition is, but =
it=20
> certainly exists in the generic code.
>=20
> --- a/libgloss/v850/_exit.c
> +++ b/libgloss/v850/_exit.c
> @@ -3,7 +3,7 @@
>  #include <sys/stat.h>
>  #include "sys/syscall.h"
> =20
> -int errno;
> +extern int errno;

why not just include errno.h ?  using `extern int errno;` is so pre-2000 :p.
-mike

--UDkAR/81OFRWN/yl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmI2gU4ACgkQQWM7n+g3
9YFXpBAAy6DE9LQTiKtujwVn28LjuEL/i43T61Hs9J345+Q3FPCv7i7dI0pN2Qpk
q9O4mrOaEnyfvu0FGm3KxOoKOIAKfoZFLvtuqYwney+mccONjfSasNKsDR+po6GN
Nzf8b3XxKHAcVsbzUXG1oVmyz0EJOU5Vr31VwHUVpEXkhyKp7YcT++o0Qo5NP9ap
nkw/66vFGwu8WG+mn1+mFUAfIwqcDYvUO5HH0eAHtoMfJqUwol1qbksoX8ldWuaI
wV5Sa0UsqPg2Tgqtsld1l3k/qu/XZu0MO33n0gxB8RB32DMoXf3iZkSgFOqUJq5h
aRUTwpkIjBjuaC5oFp+8UQE6Thg3yq9dtLgNx2MwyyUAbtBDHdsYG1t4dAzZSCiS
V3NUCa86PhSpUOYYAG8H0UkvxDmeK2BWZ40rHg95PGYA7OQW0J4bYa73T9BBMH4P
9UaLpb/zhuOzMpcsl6/SvbSwnd6OwrRq3ghjv1TBZBHu6luPk24L/k17MxMYDGih
zwgJyDzk3ksJQ10m1VzdzteV0k9RRQQho21t6LGCKJc2JIQrDRTQYMNG0IMT/5lH
9+te4AS3pi/hYt4U24Kdj5IojzR8157Mdz2AfK+NG5ikHbRzkkeZM8SHfr6OGfKF
Uf+vYhSVS5aYCk7Lto8yr3xvDTFl4h6HM33qjUGBIMlmSSAKMbU=
=BE/+
-----END PGP SIGNATURE-----

--UDkAR/81OFRWN/yl--