From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 976A03945C3D for ; Fri, 1 Apr 2022 13:02:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 976A03945C3D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648818136; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TmitdMTlufAM3iSjOFgJaIz+vVyebuL+KzmLaK/VXLg=; b=ZsukHjVv4InK7NYsJAOZhQhvjfa6KDYgI+MoAsJG7N+3OMpX/pH1yF4SgERYFtdptTqyGX l43xwOmcd8slnL1hLEWv9dU7PpuYjr8DkIdD90LWa3JvEZ/rmGJ/APN9ryqNYMFLcYYi4D 1H4WT5ozmbJu7OFFMt3o8XSG7w9m/H8= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-43-15xLJYsSNo6RzZTqzrr42g-1; Fri, 01 Apr 2022 09:02:13 -0400 X-MC-Unique: 15xLJYsSNo6RzZTqzrr42g-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9D1891C04B7E; Fri, 1 Apr 2022 13:02:12 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4AA282166B26; Fri, 1 Apr 2022 13:02:12 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 977D6A80DD9; Fri, 1 Apr 2022 15:02:10 +0200 (CEST) Date: Fri, 1 Apr 2022 15:02:10 +0200 From: Corinna Vinschen To: jdoubleu Cc: newlib@sourceware.org Subject: Re: [PATCH] fix testsuite Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: jdoubleu , newlib@sourceware.org References: <15d2933b-defd-f5d2-c402-7882dc20271c@jdoubleu.de> MIME-Version: 1.0 In-Reply-To: <15d2933b-defd-f5d2-c402-7882dc20271c@jdoubleu.de> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Apr 2022 13:02:18 -0000 Hi J, On Mar 24 17:54, jdoubleu wrote: > I found the issue: newlib/testsuite/lib/passfail.exp was using a the > function `newlib_target_compile` which is defined in newlib.exp but hasn't > been included yet. > > I attached a patch. > > Still some tests fail to compile, but that seems more like an issue with the > host environment or target board. Could you please add the description of the error you're seeing to the commit message of your patch, kind of as in your below first mail? Just "Fix testsuite" is a bit on the terse side :) Thanks, Corinna > > > Cheers > --- > 🙎🏻‍♂️ jdoubleu > On 3/21/2022 4:37 PM, jdoubleu wrote: > > Hi, > > > > I'm currently trying to run the newlib testsuite on my linux host. > > Unforunately, it looks like the tests cannot be compiled (by DEJAGNU). > > > > I've followed the steps in https://sourceware.org/git/?p=newlib-cygwin.git;a=blob;f=newlib/README;h=97890b9d20ca0ac9f206d7a2334d55a3d7052289;hb=HEAD#l470 > > to setup and configure my environment. > > > > I'm getting the following stack trace when I run `make check`: > > ``` > > $ make check > > ... > > make[1]: Entering directory '/path/to/newlib-cygwin/build' > > Found expect: expect > > Found runtest: runtest > > /path/to/newlib-cygwin/build/testsuite > > WARNING: Couldn't find tool init file > > Test run by jdoubleu on Mon Mar 21 16:27:27 2022 > > Target is x86_64-pc-linux-gnu > > Host   is x86_64-pc-linux-gnu > > > >                 === newlib tests === > > > > Schedule of variations: > >     unix > > > > Running target unix > > Using /usr/share/dejagnu/baseboards/unix.exp as board description file > > for target. > > Using /usr/share/dejagnu/config/unix.exp as generic interface file for > > target. > > Using /path/to/newlib-cygwin/newlib/testsuite/config/default.exp as > > tool-and-target-specific interface file. > > WARNING: Assuming target board is the local machine (which is probably > > wrong). > > You may need to set your DEJAGNU environment variable. > > Running /path/to/newlib-cygwin/newlib/testsuite/newlib.elix/elix.exp ... > > Running /path/to/newlib-cygwin/newlib/testsuite/newlib.iconv/iconv.exp ... > > ERROR: (DejaGnu) proc "newlib_target_compile > > /path/to/newlib-cygwin/newlib/testsuite/newlib.iconv/iconvnm.c > > /path/to/newlib-cygwin/build/testsuite/iconvnm.x executable {}" does not > > exist. > > The error code is TCL LOOKUP COMMAND newlib_target_compile > > The info on the error is: > > invalid command name "newlib_target_compile" > >     while executing > > "::tcl_unknown newlib_target_compile > > /path/to/newlib-cygwin/newlib/testsuite/newlib.iconv/iconvnm.c > > /path/to/newli..." > >     ("uplevel" body line 1) > >     invoked from within > > "uplevel 1 ::tcl_unknown $args" > > > >                 === newlib Summary === > > > > make[1]: Leaving directory '/path/to/newlib-cygwin/build' > > ``` > > > > Building the lib (`make`) works. > > > > I've also noticed, the docs are mentioning to run `make > > check-target-newlib` (see https://sourceware.org/git/?p=newlib-cygwin.git;a=blob;f=newlib/README;h=97890b9d20ca0ac9f206d7a2334d55a3d7052289;hb=HEAD#l505), > > which does not seem to exist. I could only run `check` which eventually > > runs `check-DEJAGNU`. > > > > > > Best regards > From 367bac5167e3c24b26310bafd59a26dc548a3a33 Mon Sep 17 00:00:00 2001 > From: jdoubleu > Date: Thu, 24 Mar 2022 17:49:08 +0100 > Subject: [PATCH] fix testsuite > > --- > newlib/testsuite/lib/passfail.exp | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/newlib/testsuite/lib/passfail.exp b/newlib/testsuite/lib/passfail.exp > index 5e7eb21..2c9abf6 100644 > --- a/newlib/testsuite/lib/passfail.exp > +++ b/newlib/testsuite/lib/passfail.exp > @@ -4,6 +4,8 @@ > # is freely granted, provided that this notice is preserved. > # > > +load_lib newlib.exp > + > # newlib_pass_fail_all compiles and runs all the source files in the > # test directory. If flag is -x, then the sources whose basenames are > # listed in exclude_list are not compiled and run. > -- > 2.35.1 >