From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 689503858427 for ; Fri, 1 Apr 2022 13:38:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 689503858427 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648820325; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=fDGkvknHFnBcIi3KdmXzUKOaypiB76Nec7UtRiKDOJ8=; b=bonK3LhjSXv6uYU9B9WbGD4P/y8qC0sIYJkEULHePtK380IgscihC5hT3GvLdGPEy56CHH G84Szb54PKgt4OoF8dDgW7GEFe7SHsFvFZHhftt0nUvi7jtSCs/m+4qJyAjfJbQfU7cbSq Dl2oTyp3qflMy6xXG+n8Xsgf99sRZgU= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-513-_911acWMNPe576AA0iGmUQ-1; Fri, 01 Apr 2022 09:38:44 -0400 X-MC-Unique: _911acWMNPe576AA0iGmUQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BD8A83C1EA58 for ; Fri, 1 Apr 2022 13:38:43 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8D43A1121314 for ; Fri, 1 Apr 2022 13:38:43 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 82B98A80DD9; Fri, 1 Apr 2022 15:38:41 +0200 (CEST) Date: Fri, 1 Apr 2022 15:38:41 +0200 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] newlib: Remove unused CHECK_STD_INIT() macro Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220331065221.1970-1-sebastian.huber@embedded-brains.de> MIME-Version: 1.0 In-Reply-To: <20220331065221.1970-1-sebastian.huber@embedded-brains.de> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Apr 2022 13:38:46 -0000 On Mar 31 08:52, Sebastian Huber wrote: > --- > newlib/libc/stdio/local.h | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/newlib/libc/stdio/local.h b/newlib/libc/stdio/local.h > index 86422eb11..e14586f35 100644 > --- a/newlib/libc/stdio/local.h > +++ b/newlib/libc/stdio/local.h > @@ -221,15 +221,6 @@ extern _READ_WRITE_RETURN_TYPE __swrite64 (struct _reent *, void *, > while (0) > #endif /* !_REENT_SMALL || _REENT_GLOBAL_STDIO_STREAMS */ > > -#define CHECK_STD_INIT(ptr) \ > - do \ > - { \ > - struct _reent *_check_init_ptr = (ptr); \ > - if ((_check_init_ptr) && !(_check_init_ptr)->__cleanup) \ > - __sinit (_check_init_ptr); \ > - } \ > - while (0) > - > /* Return true and set errno and stream error flag iff the given FILE > cannot be written now. */ This patch is kind of obvious, but then again it should drop CHECK_STD_INIT from libc/machine/spu/c99ppe.h and all its usages within libc/machine/spu as well. Thanks, Corinna