public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] libgloss: pru: Fix _open syscal arguments
@ 2022-04-03 18:57 Dimitar Dimitrov
  2022-04-27  9:44 ` Corinna Vinschen
  0 siblings, 1 reply; 2+ messages in thread
From: Dimitar Dimitrov @ 2022-04-03 18:57 UTC (permalink / raw)
  To: newlib

The _open() C function is declared as having variable arguments in
newlib, so second and third arguments are passed on stack. Add code to
move them into registers, since that's where the PRU simulator expects
them.

Issue was exposed by the GCC test gcc.c-torture/execute/fprintf-2.c,
which relies on tmpnam implementation to pass correct flags to _open.

Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
---
 libgloss/pru/syscalls.S | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/libgloss/pru/syscalls.S b/libgloss/pru/syscalls.S
index 252231e90..80486d1f9 100644
--- a/libgloss/pru/syscalls.S
+++ b/libgloss/pru/syscalls.S
@@ -68,7 +68,6 @@ __SC_ret_skip_errno_set:
 	   users use other methods for communicating with
 	   the host - remoteproc, rpmsg, shared memory.  */
 	SC	_exit, SYS_exit
-	SC	_open, SYS_open
 	SC	_close, SYS_close
 	SC	_read, SYS_read
 	SC	_write, SYS_write
@@ -77,3 +76,20 @@ __SC_ret_skip_errno_set:
 	SC	_getpid, SYS_getpid
 	SC	_kill, SYS_kill
 	SC	_fstat, SYS_fstat
+
+
+	/* _open is special because it has VA declaration. */
+	.section .text._open, "ax"
+	.global	_open
+	.type	_open,@function
+	.func
+_open:
+	/* Pop the second and third argument from stack, per VA ABI.
+	   Thus simulator can get all arguments from registers
+	   for any supported syscall.  */
+	lbbo    r16, sp, 4, 4
+	lbbo    r15, sp, 0, 4
+	ldi	r1, SYS_open
+	halt
+	jmp	__SC_ret
+	.endfunc
-- 
2.35.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] libgloss: pru: Fix _open syscal arguments
  2022-04-03 18:57 [PATCH] libgloss: pru: Fix _open syscal arguments Dimitar Dimitrov
@ 2022-04-27  9:44 ` Corinna Vinschen
  0 siblings, 0 replies; 2+ messages in thread
From: Corinna Vinschen @ 2022-04-27  9:44 UTC (permalink / raw)
  To: Dimitar Dimitrov; +Cc: newlib

On Apr  3 21:57, Dimitar Dimitrov wrote:
> The _open() C function is declared as having variable arguments in
> newlib, so second and third arguments are passed on stack. Add code to
> move them into registers, since that's where the PRU simulator expects
> them.
> 
> Issue was exposed by the GCC test gcc.c-torture/execute/fprintf-2.c,
> which relies on tmpnam implementation to pass correct flags to _open.
> 
> Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
> ---
>  libgloss/pru/syscalls.S | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)

Pushed. Sorry for the delay.


Thanks,
Corinna


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-04-27  9:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-03 18:57 [PATCH] libgloss: pru: Fix _open syscal arguments Dimitar Dimitrov
2022-04-27  9:44 ` Corinna Vinschen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).