From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4AE7D3858C54 for ; Wed, 27 Apr 2022 09:44:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4AE7D3858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651052650; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=X+vcoKc2OsEC/twzxXkshZaclnzqrZo8EtgAvy4ou3g=; b=Ft5eZbjEa7LDKxamdIWjhtR/jqwiD/bnFGmgfJNULzYJFJ9PhN1XxCPPgI/dc3GYnWRl2D yxhAdEf3OwOd81lz2tEuQqVxTe5F5W+Nn6mTeKujPfutdBq354VgiFgwzSSpJW7JMM33PX RSldsFwdE6R/CEneozj2sITPGLmZ95Y= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-294-nAHGoo9sP2iDystjM-0vgw-1; Wed, 27 Apr 2022 05:44:07 -0400 X-MC-Unique: nAHGoo9sP2iDystjM-0vgw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B119D8039D7; Wed, 27 Apr 2022 09:44:06 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8CC229E69; Wed, 27 Apr 2022 09:44:06 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 0C79AA80772; Wed, 27 Apr 2022 11:44:05 +0200 (CEST) Date: Wed, 27 Apr 2022 11:44:05 +0200 From: Corinna Vinschen To: Dimitar Dimitrov Cc: newlib@sourceware.org Subject: Re: [PATCH] libgloss: pru: Fix _open syscal arguments Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: Dimitar Dimitrov , newlib@sourceware.org References: <20220403185739.2997679-1-dimitar@dinux.eu> MIME-Version: 1.0 In-Reply-To: <20220403185739.2997679-1-dimitar@dinux.eu> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Apr 2022 09:44:11 -0000 On Apr 3 21:57, Dimitar Dimitrov wrote: > The _open() C function is declared as having variable arguments in > newlib, so second and third arguments are passed on stack. Add code to > move them into registers, since that's where the PRU simulator expects > them. > > Issue was exposed by the GCC test gcc.c-torture/execute/fprintf-2.c, > which relies on tmpnam implementation to pass correct flags to _open. > > Signed-off-by: Dimitar Dimitrov > --- > libgloss/pru/syscalls.S | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) Pushed. Sorry for the delay. Thanks, Corinna