From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B7CAF385737E for ; Thu, 12 May 2022 16:05:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B7CAF385737E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652371519; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=YcDGzpDnrOCrxEZLBkP3a7t849aPXJM+xnpD64uOmNA=; b=MK85En9QsT+Llt9nhcMgc1ic92ldD67RPUZ53IX+yn6bkJDsU6zEctpRSjRkKQUZpw0+R/ dti+fMgXUGEgKaKZOXlSuCKqRzBEqROtnChEvpGGLUlTTWPjS2hpsl4pOXw1IYYVSXOIuT QvR3Dt2HbD1I0rFTB3yflF3jx9E24qU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-649-eDIAsni-NdyyfKIlc62mqw-1; Thu, 12 May 2022 12:05:18 -0400 X-MC-Unique: eDIAsni-NdyyfKIlc62mqw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E8B1B833967 for ; Thu, 12 May 2022 16:05:17 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.8]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C4C432166B25 for ; Thu, 12 May 2022 16:05:17 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 8CEA0A80965; Thu, 12 May 2022 18:05:16 +0200 (CEST) Date: Thu, 12 May 2022 18:05:16 +0200 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] Cygwin: signal.cc: Include Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220512064332.23298-1-sebastian.huber@embedded-brains.de> <0856b9dc-ef50-234e-9327-32eff276dda4@SystematicSw.ab.ca> MIME-Version: 1.0 In-Reply-To: <0856b9dc-ef50-234e-9327-32eff276dda4@SystematicSw.ab.ca> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2022 16:05:21 -0000 On May 12 08:48, Brian Inglis wrote: > On 2022-05-12 02:46, Corinna Vinschen wrote: > > On May 12 10:22, Sebastian Huber wrote: > > > On 12/05/2022 10:14, Corinna Vinschen wrote: > > > > > sleep (unsigned int seconds) > > > > > { > > > > > struct timespec req, rem; > > > > > @@ -174,7 +175,7 @@ sleep (unsigned int seconds) > > > > > return 0; > > > > > } > > > > > -extern "C" unsigned int > > > > > +int > > > > > usleep (useconds_t useconds) > > > > Good catch, otherwise, thank you! I'd prefer if you push just the > > > > type change and keep the extern "C" as a marker for exported functions. > > > > > > Ok, what about the unistd.h include? > > > > Let's keep it. It might help to uncover other issues in future. > > Shouldn't these Cygwin winsup patches be posted separately to > cygwin-patches rather than newlib, once any newlib patches they depend on > have been accepted. Not really. If the patch changes something generic which Cygwin uses, then the patch should ideally contain the required Cygwin patch, too. Otherwise you'd have a deliberately build breakage in git history. We have a few of them in the past, they are a PITA. Corinna