public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH v2 11/11] Remove __sglue member for one configuration
Date: Thu, 12 May 2022 21:09:43 +0200	[thread overview]
Message-ID: <Yn1bd8StS/m6Fbk2@calimero.vinschen.de> (raw)
In-Reply-To: <20220512121143.21473-12-matthew.joyce@embedded-brains.de>

On May 12 14:11, Matthew Joyce wrote:
> From: Matt Joyce <matthew.joyce@embedded-brains.de>
> 
> Removed __sglue member of struct reent when
> _REENT_GLOBAL_STDIO_STREAMS is defined.
> ---
>  newlib/libc/include/sys/reent.h | 8 ++++----
>  newlib/libc/reent/reent.c       | 6 +++++-
>  newlib/libc/stdio/fcloseall.c   | 5 +++++
>  newlib/libc/stdio/findfp.c      | 9 ++++++++-
>  4 files changed, 22 insertions(+), 6 deletions(-)

This patch requires another change in Cygwin.

For some reason, entirely lost in the mist of time, Cygwin exports the
cleanup_glue function.  It already did so when winsup and newlib sources
have been imported into the sourceware CVS repo, back in 2000.

At this point I'd usually say that we can't change that because backward
compatibility and yada yada, but it just doesn't make any sense to export
cleanup_glue, and never did.  At all.

So, instead of reverting cleanup_glue to non-static, let's pull this
through and let's drop it from the list of exported functions.

That means, this patch needs a tiny extension and the commit message
should mention that it's removing cleanup_glue from the list of exported
symbols.

Here's the diff of the required change, please add it to this patch:

diff --git a/winsup/cygwin/common.din b/winsup/cygwin/common.din
index 63fa09af2553..751ab3754421 100644
--- a/winsup/cygwin/common.din
+++ b/winsup/cygwin/common.din
@@ -316,7 +316,6 @@ chroot SIGFE
 cimag NOSIGFE
 cimagf NOSIGFE
 cimagl NOSIGFE
-cleanup_glue NOSIGFE
 clearenv SIGFE
 clearerr SIGFE
 clearerr_unlocked SIGFE
diff --git a/winsup/cygwin/include/cygwin/version.h b/winsup/cygwin/include/cygwin/version.h
index ad7fab43f458..6f65a12994bc 100644
--- a/winsup/cygwin/include/cygwin/version.h
+++ b/winsup/cygwin/include/cygwin/version.h
@@ -516,12 +516,13 @@ details. */
   341: Export pthread_cond_clockwait, pthread_mutex_clocklock,
        pthread_rwlock_clockrdlock, pthread_rwlock_clockwrlock,
        sem_clockwait, sig2str, str2sig.
+  342: Remove cleanup_glue.
 
   Note that we forgot to bump the api for ualarm, strtoll, strtoull,
   sigaltstack, sethostname. */
 
 #define CYGWIN_VERSION_API_MAJOR 0
-#define CYGWIN_VERSION_API_MINOR 341
+#define CYGWIN_VERSION_API_MINOR 342
 
 /* There is also a compatibity version number associated with the shared memory
    regions.  It is incremented when incompatible changes are made to the shared


Thanks,
Corinna


  reply	other threads:[~2022-05-12 19:09 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-12 12:11 [PATCH v2 00/11] Decouple global file object list from _GLOBAL_REENT Matthew Joyce
2022-05-12 12:11 ` [PATCH v2 01/11] Remove duplicate stdio initializations Matthew Joyce
2022-05-12 12:11 ` [PATCH v2 02/11] Remove duplicate sglue initializations Matthew Joyce
2022-05-12 12:11 ` [PATCH v2 03/11] Declare global __sf[] only once Matthew Joyce
2022-05-12 12:11 ` [PATCH v2 04/11] Add two __sglue initialization macros Matthew Joyce
2022-05-12 12:11 ` [PATCH v2 05/11] Remove __sinit_locks / __sinit_recursive_mutex Matthew Joyce
2022-05-12 13:25   ` Torbjorn SVENSSON
2022-05-12 13:51     ` Sebastian Huber
2022-05-12 12:11 ` [PATCH v2 06/11] Move __sglue initializations to __sfp() Matthew Joyce
2022-05-12 12:11 ` [PATCH v2 07/11] Add CLEANUP_FILE define Matthew Joyce
2022-05-12 12:11 ` [PATCH v2 08/11] Add stdio_exit_handler() Matthew Joyce
2022-05-12 19:11   ` Corinna Vinschen
2022-05-17  8:36   ` Takashi Yano
2022-05-17 10:13     ` Sebastian Huber
2022-05-12 12:11 ` [PATCH v2 09/11] stdio: Replace _fwalk_reent() with _fwalk_sglue() Matthew Joyce
2022-05-12 12:11 ` [PATCH v2 10/11] Add global __sglue object for all configurations Matthew Joyce
2022-05-12 12:11 ` [PATCH v2 11/11] Remove __sglue member for one configuration Matthew Joyce
2022-05-12 19:09   ` Corinna Vinschen [this message]
2022-05-12 19:14 ` [PATCH v2 00/11] Decouple global file object list from _GLOBAL_REENT Corinna Vinschen
2022-05-12 19:44   ` Corinna Vinschen
2022-05-13  5:44     ` Sebastian Huber
2022-05-13  7:53       ` Corinna Vinschen
2022-05-13 10:54     ` Sebastian Huber
2022-05-13 11:20       ` Corinna Vinschen
2022-05-13  8:03   ` Corinna Vinschen
2022-05-13 11:20     ` Sebastian Huber
2022-05-13 11:30       ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yn1bd8StS/m6Fbk2@calimero.vinschen.de \
    --to=vinschen@redhat.com \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).