From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 60F183857349 for ; Thu, 12 May 2022 19:09:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 60F183857349 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652382586; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=CH7UYBrHoNMWveSBtc/cOKMJM+UdTS5TKqWYiEe5Rfc=; b=dhitdxcs3SzYM0CYIcd7Q6nR3msQAlvGyl0KIDuWmHx3pSUz8+SxWh+FwFxOATRbekuEqL NP5fWJkn2gD8fi+1sQOZowoCPQp+RUWnYs8UkNpQTwcChmfgYhxWHJbNq4yO3bx7lkrZS4 47UO97ZMgn8W5X/oXRGPsnCda35TXbU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-662-Db8l5b5SMrWhbWscTqxmSA-1; Thu, 12 May 2022 15:09:44 -0400 X-MC-Unique: Db8l5b5SMrWhbWscTqxmSA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9ED41802A5B for ; Thu, 12 May 2022 19:09:44 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.8]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7A6A62166B25 for ; Thu, 12 May 2022 19:09:44 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 47602A80884; Thu, 12 May 2022 21:09:43 +0200 (CEST) Date: Thu, 12 May 2022 21:09:43 +0200 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH v2 11/11] Remove __sglue member for one configuration Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220512121143.21473-1-matthew.joyce@embedded-brains.de> <20220512121143.21473-12-matthew.joyce@embedded-brains.de> MIME-Version: 1.0 In-Reply-To: <20220512121143.21473-12-matthew.joyce@embedded-brains.de> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2022 19:09:47 -0000 On May 12 14:11, Matthew Joyce wrote: > From: Matt Joyce > > Removed __sglue member of struct reent when > _REENT_GLOBAL_STDIO_STREAMS is defined. > --- > newlib/libc/include/sys/reent.h | 8 ++++---- > newlib/libc/reent/reent.c | 6 +++++- > newlib/libc/stdio/fcloseall.c | 5 +++++ > newlib/libc/stdio/findfp.c | 9 ++++++++- > 4 files changed, 22 insertions(+), 6 deletions(-) This patch requires another change in Cygwin. For some reason, entirely lost in the mist of time, Cygwin exports the cleanup_glue function. It already did so when winsup and newlib sources have been imported into the sourceware CVS repo, back in 2000. At this point I'd usually say that we can't change that because backward compatibility and yada yada, but it just doesn't make any sense to export cleanup_glue, and never did. At all. So, instead of reverting cleanup_glue to non-static, let's pull this through and let's drop it from the list of exported functions. That means, this patch needs a tiny extension and the commit message should mention that it's removing cleanup_glue from the list of exported symbols. Here's the diff of the required change, please add it to this patch: diff --git a/winsup/cygwin/common.din b/winsup/cygwin/common.din index 63fa09af2553..751ab3754421 100644 --- a/winsup/cygwin/common.din +++ b/winsup/cygwin/common.din @@ -316,7 +316,6 @@ chroot SIGFE cimag NOSIGFE cimagf NOSIGFE cimagl NOSIGFE -cleanup_glue NOSIGFE clearenv SIGFE clearerr SIGFE clearerr_unlocked SIGFE diff --git a/winsup/cygwin/include/cygwin/version.h b/winsup/cygwin/include/cygwin/version.h index ad7fab43f458..6f65a12994bc 100644 --- a/winsup/cygwin/include/cygwin/version.h +++ b/winsup/cygwin/include/cygwin/version.h @@ -516,12 +516,13 @@ details. */ 341: Export pthread_cond_clockwait, pthread_mutex_clocklock, pthread_rwlock_clockrdlock, pthread_rwlock_clockwrlock, sem_clockwait, sig2str, str2sig. + 342: Remove cleanup_glue. Note that we forgot to bump the api for ualarm, strtoll, strtoull, sigaltstack, sethostname. */ #define CYGWIN_VERSION_API_MAJOR 0 -#define CYGWIN_VERSION_API_MINOR 341 +#define CYGWIN_VERSION_API_MINOR 342 /* There is also a compatibity version number associated with the shared memory regions. It is incremented when incompatible changes are made to the shared Thanks, Corinna