From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH v2 00/11] Decouple global file object list from _GLOBAL_REENT
Date: Fri, 13 May 2022 09:53:02 +0200 [thread overview]
Message-ID: <Yn4OXuahHprQldHA@calimero.vinschen.de> (raw)
In-Reply-To: <cd0142c9-1299-4f7e-ce06-5c2ace19e665@embedded-brains.de>
On May 13 07:44, Sebastian Huber wrote:
> On 12/05/2022 21:44, Corinna Vinschen wrote:
> > diff --git a/winsup/cygwin/cygtls.cc b/winsup/cygwin/cygtls.cc
> > index c8352adf9f25..0fd5509d2306 100644
> > --- a/winsup/cygwin/cygtls.cc
> > +++ b/winsup/cygwin/cygtls.cc
> > @@ -55,16 +55,8 @@ _cygtls::init_thread (void *x, DWORD (*func) (void *, void *))
> > _REENT_INIT_PTR (&local_clib);
> > stackptr = stack;
> > altstack.ss_flags = SS_DISABLE;
> > - if (_GLOBAL_REENT)
> > - {
> > - local_clib._stdin = _GLOBAL_REENT->_stdin;
> > - local_clib._stdout = _GLOBAL_REENT->_stdout;
> > - local_clib._stderr = _GLOBAL_REENT->_stderr;
> > - if (_GLOBAL_REENT->__cleanup)
> > - local_clib.__cleanup = _cygtls::cleanup_early;
> > - local_clib.__sglue._niobs = 3;
> > - local_clib.__sglue._iobs = &_GLOBAL_REENT->__sf[0];
> > - }
> > + if (_GLOBAL_REENT && _GLOBAL_REENT->__cleanup)
> > + local_clib.__cleanup = _cygtls::cleanup_early;
>
> We have:
>
> #define _GLOBAL_REENT (&_impure_data)
>
> So, the NULL pointer check is superfluous.
Oh, right, thanks!
Corinna
next prev parent reply other threads:[~2022-05-13 7:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 12:11 Matthew Joyce
2022-05-12 12:11 ` [PATCH v2 01/11] Remove duplicate stdio initializations Matthew Joyce
2022-05-12 12:11 ` [PATCH v2 02/11] Remove duplicate sglue initializations Matthew Joyce
2022-05-12 12:11 ` [PATCH v2 03/11] Declare global __sf[] only once Matthew Joyce
2022-05-12 12:11 ` [PATCH v2 04/11] Add two __sglue initialization macros Matthew Joyce
2022-05-12 12:11 ` [PATCH v2 05/11] Remove __sinit_locks / __sinit_recursive_mutex Matthew Joyce
2022-05-12 13:25 ` Torbjorn SVENSSON
2022-05-12 13:51 ` Sebastian Huber
2022-05-12 12:11 ` [PATCH v2 06/11] Move __sglue initializations to __sfp() Matthew Joyce
2022-05-12 12:11 ` [PATCH v2 07/11] Add CLEANUP_FILE define Matthew Joyce
2022-05-12 12:11 ` [PATCH v2 08/11] Add stdio_exit_handler() Matthew Joyce
2022-05-12 19:11 ` Corinna Vinschen
2022-05-17 8:36 ` Takashi Yano
2022-05-17 10:13 ` Sebastian Huber
2022-05-12 12:11 ` [PATCH v2 09/11] stdio: Replace _fwalk_reent() with _fwalk_sglue() Matthew Joyce
2022-05-12 12:11 ` [PATCH v2 10/11] Add global __sglue object for all configurations Matthew Joyce
2022-05-12 12:11 ` [PATCH v2 11/11] Remove __sglue member for one configuration Matthew Joyce
2022-05-12 19:09 ` Corinna Vinschen
2022-05-12 19:14 ` [PATCH v2 00/11] Decouple global file object list from _GLOBAL_REENT Corinna Vinschen
2022-05-12 19:44 ` Corinna Vinschen
2022-05-13 5:44 ` Sebastian Huber
2022-05-13 7:53 ` Corinna Vinschen [this message]
2022-05-13 10:54 ` Sebastian Huber
2022-05-13 11:20 ` Corinna Vinschen
2022-05-13 8:03 ` Corinna Vinschen
2022-05-13 11:20 ` Sebastian Huber
2022-05-13 11:30 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yn4OXuahHprQldHA@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).