From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id A6E243857349 for ; Fri, 13 May 2022 11:30:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A6E243857349 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652441408; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=RQ8SLhaHtP4dQAJgrRPNQOhLBG0xPigqE+w791HaZVY=; b=QAZ0WvDIZb1BjPDWTY6Z95znCHQGkW+LvodHm1N7Wv8/5GUV/aW1UqJ+zSY9ZiQOtN0F4r cwkv3a11XLKMLkXWTbr9i9d50ZYVseYaynVc6waWTKtfHG5VKmPdE3eWyuuyN2j2xYmo20 wYscFAPGX7UrCfcrwfho4PTpf+j5qzk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-82-pLOaV3hiM6ubjLBpOd3PQA-1; Fri, 13 May 2022 07:30:07 -0400 X-MC-Unique: pLOaV3hiM6ubjLBpOd3PQA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CE101185A7B2 for ; Fri, 13 May 2022 11:30:06 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.8]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AA2DC111F3BB for ; Fri, 13 May 2022 11:30:06 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 46875A808A0; Fri, 13 May 2022 13:30:05 +0200 (CEST) Date: Fri, 13 May 2022 13:30:05 +0200 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH v2 00/11] Decouple global file object list from _GLOBAL_REENT Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220512121143.21473-1-matthew.joyce@embedded-brains.de> <59d3e179-d25c-04e9-08bb-da292fffae75@embedded-brains.de> MIME-Version: 1.0 In-Reply-To: <59d3e179-d25c-04e9-08bb-da292fffae75@embedded-brains.de> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 May 2022 11:30:09 -0000 On May 13 13:20, Sebastian Huber wrote: > On 13/05/2022 10:03, Corinna Vinschen wrote: > > Hi Sebastian, Hi Matt, > > > > On May 12 21:14, Corinna Vinschen wrote: > > > Hi Matt, > > > > > > On May 12 14:11, Matthew Joyce wrote: > > > > From: Matt Joyce > > > > > > > > Hello Corinna, > > > > > > > > Per your comments, please see version 2. > > > > > > > > 1) stdio_atexit is now called stdio_exit_handler > > > > 2) declarations for stdio_exit_handler() and _fwalk_sglue() are moved > > > > to sys/reent.h > > > > > > Please see my comments in terms of patch 11, which needs an additional > > > tweak. With this change, the patchset is GTG. > > > > I forgot to mention... you don't have to send a v3, just push the > > patchset with this additional tweak (and talk about it in the commit > > message). > > Thanks for the review. I checked it in with hopefully the right additional > tweaks. LGTM. Thanks, Corinna