From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id BDE983856DE3 for ; Wed, 4 May 2022 13:12:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BDE983856DE3 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651669939; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=JCCw6FzDeFF8nhRAww8BuM3DPVzPnQDG3cGbJAJnhoM=; b=SVSZ5/+S7YiUGIDFLYfZ4b5Ftzr1j6Pihq8MS0YagJrJPUnnIqoNlcHNDwQuPkN+OwwX/J YdBPdiEAnOR0NyUvyRld40oF5cJnb2Dl1Xu/CAMUozVmb0Gvx46TTDmJKcKnSglhJmY1ap oUjtJSzFtkoLE8olXjvpJDi1Dhvpk5c= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-618-MelbaBLdPeyi_uEfAk9tYw-1; Wed, 04 May 2022 09:12:18 -0400 X-MC-Unique: MelbaBLdPeyi_uEfAk9tYw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 18E301014A67 for ; Wed, 4 May 2022 13:12:18 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E8D272026D2D for ; Wed, 4 May 2022 13:12:17 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id B3A55A80884; Wed, 4 May 2022 15:12:16 +0200 (CEST) Date: Wed, 4 May 2022 15:12:16 +0200 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: Issue: #include shall not cause intmax_t to be defined Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <9dbc482d-84fd-b3be-babc-e00040a56f5b@embedded-brains.de> MIME-Version: 1.0 In-Reply-To: <9dbc482d-84fd-b3be-babc-e00040a56f5b@embedded-brains.de> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2022 13:12:21 -0000 On May 4 11:02, Sebastian Huber wrote: > On 04/05/2022 10:54, Corinna Vinschen wrote: > > On May 4 10:41, Sebastian Huber wrote: > > > On 04/05/2022 10:37, Corinna Vinschen wrote: > > > > On May 4 09:59, Sebastian Huber wrote: > > > > > On 03/05/2022 19:00, Corinna Vinschen wrote: > > > > > > On Apr 27 00:41, Pavel M wrote: > > > > > > > Hi all, > > > > > > > > > > > > > > Issue: #include shall not cause intmax_t to be defined. However, > > > > > > > now it causes. This is because now includes , which > > > > > > > includes . > > > > > > > Note: per C11 the types intmax_t and uintmax_t defined in the header > > > > > > > , and is not included in . > > > > > > > Consider fixing. > > > > > > I pushed a patch to fix this. > > > > > In FreeBSD, provides the stdint.h types. Could we bring back > > > > > this with > > > > Is that with FreeeBSD only, or is that with BSDs in general? > > > It seems to be a general BSD feature: > > > > > > https://github.com/openbsd/src/blob/master/sys/sys/types.h#L75 > > > > > > http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/sys/types.h?rev=1.105&content-type=text/x-cvsweb-markup > > If the BSDs expose stdint.h types via stdio.h anyway, what's the sense > > of not exposing it in the non-_BSD_VISIBLE scenario? _BSD_VISIBLE is > > default anyway, so the non-exposure of the stdint types is restricted to > > files which define _XOPEN_SOURCE or some such. > > > > Is there actually a "MUST NOT" defined anywhere in the standards or > > was this change unnecessary? > > I think the reported problem with stdio.h is because the Newlib stdio.h > includes . In FreeBSD for example, is included > with local type definitions, see: > > https://sourceware.org/pipermail/newlib/2022/019592.html I guess I'm an idiot. I just dropped my patch and applied yours instead. It fixes *all* the problems requiring more patches to other files I saw while building with my change to sys/types.h. So, I think what I'll do is revert my patch and apply yours instead. The other patch of your patch series is obseleted by this. Thanks a lot! Corinna